linux-kernel - Re: [PATCH 04/15] pcmcia: synclink_cs: remove dead paranoia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 07:53:34 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     наб <nabijaczleweli@...ijaczleweli.xyz>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Haowen Bai <baihaowen@...zu.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/15] pcmcia: synclink_cs: remove dead paranoia_check,
 warn for missing line

On Thu, Oct 27, 2022 at 1:42 AM наб <nabijaczleweli@...ijaczleweli.xyz> wrote:
>
> MGSLPC_PARANOIA_CHECK has never been defined automatically,
> and devices with null driver_info can't happen, since we reject the open
> in that case
>
> Move the log statement from dead code to the check,
> and log the state inconsistency like we do above for the line count
> ("invalid line #%d.")

Please, respect English grammar and punctuation, in particular don't
forget the trailing periods.

...

> +       if (!info) {
> +               printk(KERN_WARNING "%s(%d):mgslpc_open: "
> +                       "no device for line #%d.\n",
> +                       __FILE__, __LINE__, line);

Even though the old code uses this awkward style for messages, please
follow the modern one, i.e.

               pr_warn("mgslpc_open: no device for line #%d.\n", line);

>                 return -ENODEV;
> +       }

-- 
With Best Regards,
Andy Shevchenko