linux-kernel - Re: [PATCH] ALSA: Use del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210271358.evDlsyoX-lkp@intel.com>
Date:   Thu, 27 Oct 2022 13:58:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Thomas Gleixner <tglx@...utronix.de>,
        Guenter Roeck <linux@...ck-us.net>,
        Stephen Boyd <sboyd@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: Use del_timer_sync() before freeing timer

Hi Steven,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on linux/master linus/master v6.1-rc2 next-20221027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/ALSA-Use-del_timer_sync-before-freeing-timer/20221027-111423
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20221026231236.6834b551%40gandalf.local.home
patch subject: [PATCH] ALSA: Use del_timer_sync() before freeing timer
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/998e4b5d9793fb6deb720110f9038ed04e822603
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Steven-Rostedt/ALSA-Use-del_timer_sync-before-freeing-timer/20221027-111423
        git checkout 998e4b5d9793fb6deb720110f9038ed04e822603
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/synth/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   sound/synth/emux/emux.c: In function 'snd_emux_free':
>> sound/synth/emux/emux.c:129:23: warning: unused variable 'flags' [-Wunused-variable]
     129 |         unsigned long flags;
         |                       ^~~~~


vim +/flags +129 sound/synth/emux/emux.c

^1da177e4c3f41 Linus Torvalds          2005-04-16  124  
^1da177e4c3f41 Linus Torvalds          2005-04-16  125  /*
^1da177e4c3f41 Linus Torvalds          2005-04-16  126   */
03da312ac080b4 Takashi Iwai            2005-11-17  127  int snd_emux_free(struct snd_emux *emu)
^1da177e4c3f41 Linus Torvalds          2005-04-16  128  {
^1da177e4c3f41 Linus Torvalds          2005-04-16 @129  	unsigned long flags;
^1da177e4c3f41 Linus Torvalds          2005-04-16  130  
^1da177e4c3f41 Linus Torvalds          2005-04-16  131  	if (! emu)
^1da177e4c3f41 Linus Torvalds          2005-04-16  132  		return -EINVAL;
^1da177e4c3f41 Linus Torvalds          2005-04-16  133  
998e4b5d9793fb Steven Rostedt (Google  2022-10-26  134) 	del_timer_sync(&emu->tlist);
^1da177e4c3f41 Linus Torvalds          2005-04-16  135  
^1da177e4c3f41 Linus Torvalds          2005-04-16  136  	snd_emux_proc_free(emu);
^1da177e4c3f41 Linus Torvalds          2005-04-16  137  	snd_emux_delete_virmidi(emu);
3d774d5ef06697 Takashi Iwai            2017-06-09  138  #if IS_ENABLED(CONFIG_SND_SEQUENCER_OSS)
^1da177e4c3f41 Linus Torvalds          2005-04-16  139  	snd_emux_detach_seq_oss(emu);
^1da177e4c3f41 Linus Torvalds          2005-04-16  140  #endif
^1da177e4c3f41 Linus Torvalds          2005-04-16  141  	snd_emux_detach_seq(emu);
^1da177e4c3f41 Linus Torvalds          2005-04-16  142  	snd_emux_delete_hwdep(emu);
^1da177e4c3f41 Linus Torvalds          2005-04-16  143  	snd_sf_free(emu->sflist);
^1da177e4c3f41 Linus Torvalds          2005-04-16  144  	kfree(emu->voices);
^1da177e4c3f41 Linus Torvalds          2005-04-16  145  	kfree(emu->name);
^1da177e4c3f41 Linus Torvalds          2005-04-16  146  	kfree(emu);
^1da177e4c3f41 Linus Torvalds          2005-04-16  147  	return 0;
^1da177e4c3f41 Linus Torvalds          2005-04-16  148  }
^1da177e4c3f41 Linus Torvalds          2005-04-16  149  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (291877 bytes)