linux-kernel - Re: [PATCH 1/1] clk: mxl: Fix smatch static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2022 18:05:05 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Rahul Tanwar <rtanwar@...linear.com>, dan.carpenter@...cle.com,
        linux-clk@...r.kernel.org, yzhu@...linear.com
Cc:     linux-kernel@...r.kernel.org, linux-lgm-soc@...linear.com,
        Rahul Tanwar <rtanwar@...linear.com>
Subject: Re: [PATCH 1/1] clk: mxl: Fix smatch static checker warning

Quoting Rahul Tanwar (2022-10-25 04:03:57)
> Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
> regmap based IO") introduced code resulting in below warning issued by the
> smatch static checker.
> 
>         drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe()
>         warn: passing zero to 'PTR_ERR'
> 
> Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR().
> 
> Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
> regmap based IO")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Rahul Tanwar <rtanwar@...linear.com>
> ---

Applied to clk-next

BTW, please don't send a cover letter for single patches.