linux-kernel - Re: [PATCH] staging: rtl8723bs: Replace ternary statement with min function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1oz/w9qfwQ+8gWt@kadam>
Date:   Thu, 27 Oct 2022 10:32:15 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Emily Peri <eperi1024@...il.com>
Cc:     gregkh@...uxfoundation.org, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Replace ternary statement with min
 function

On Wed, Oct 26, 2022 at 06:26:54PM -0700, Emily Peri wrote:
> Ternary statements that pick the min of two values can be replaced by
> the built-in min() function. This improves readability, since its quicker
> to understand min(x, y) than x < y ? x : y. Issue found by coccicheck.
> 
> Signed-off-by: Emily Peri <eperi1024@...il.com>

This breaks the build.  Use min_t(uint, wps_ielen, MAX_WPS_IE_LEN);

regards,
dan carpenter