lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202210271449.445fce6-oliver.sang@intel.com>
Date:   Thu, 27 Oct 2022 16:03:27 +0800
From:   kernel test robot <oliver.sang@...el.com>
To:     Kees Cook <keescook@...omium.org>
CC:     <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Andrey Konovalov <andreyknvl@...il.com>,
        David Rientjes <rientjes@...gle.com>,
        Marco Elver <elver@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-mm@...ck.org>, Kees Cook <keescook@...omium.org>,
        <linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v3] mempool: Do not use ksize() for poisoning


Greeting,

FYI, we noticed WARNING:at_kernel/locking/lockdep.c:#__lock_acquire due to commit (built with clang-14):

commit: 216fd003b5aca1c27d62df679cd722730b886919 ("[PATCH v3] mempool: Do not use ksize() for poisoning")
url: https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/mempool-Do-not-use-ksize-for-poisoning/20221026-073834
base: https://git.kernel.org/cgit/linux/kernel/git/kees/linux.git for-next/pstore
patch link: https://lore.kernel.org/linux-mm/20221025233421.you.825-kees@kernel.org
patch subject: [PATCH v3] mempool: Do not use ksize() for poisoning

in testcase: boot

on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):


If you fix the issue, kindly add following tag
| Reported-by: kernel test robot <oliver.sang@...el.com>
| Link: https://lore.kernel.org/oe-lkp/202210271449.445fce6-oliver.sang@intel.com


[    4.181184][    T1] ------------[ cut here ]------------
[    4.181613][    T1] DEBUG_LOCKS_WARN_ON(1)
[ 4.181613][ T1] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:231 __lock_acquire (lockdep.c:?) 
[    4.181613][    T1] Modules linked in:
[    4.181613][    T1] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc1-00012-g216fd003b5ac #1
[    4.181613][    T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-4 04/01/2014
[ 4.181613][ T1] EIP: __lock_acquire (lockdep.c:?) 
[ 4.181613][ T1] Code: bd 96 00 85 c0 0f 84 b4 02 00 00 83 3d b8 c0 4c 45 00 0f 85 a7 02 00 00 68 c3 07 29 44 68 44 7b 13 44 e8 a7 53 f8 ff 83 c4 08 <0f> 0b 8b 4d f0 eb 09 6b c0 64 8d b0 10 38 71 45 8a 5e 60 b8 ff 1f
All code
========
   0:	bd 96 00 85 c0       	mov    $0xc0850096,%ebp
   5:	0f 84 b4 02 00 00    	je     0x2bf
   b:	83 3d b8 c0 4c 45 00 	cmpl   $0x0,0x454cc0b8(%rip)        # 0x454cc0ca
  12:	0f 85 a7 02 00 00    	jne    0x2bf
  18:	68 c3 07 29 44       	pushq  $0x442907c3
  1d:	68 44 7b 13 44       	pushq  $0x44137b44
  22:	e8 a7 53 f8 ff       	callq  0xfffffffffff853ce
  27:	83 c4 08             	add    $0x8,%esp
  2a:*	0f 0b                	ud2    		<-- trapping instruction
  2c:	8b 4d f0             	mov    -0x10(%rbp),%ecx
  2f:	eb 09                	jmp    0x3a
  31:	6b c0 64             	imul   $0x64,%eax,%eax
  34:	8d b0 10 38 71 45    	lea    0x45713810(%rax),%esi
  3a:	8a 5e 60             	mov    0x60(%rsi),%bl
  3d:	b8                   	.byte 0xb8
  3e:	ff 1f                	lcall  *(%rdi)

Code starting with the faulting instruction
===========================================
   0:	0f 0b                	ud2    
   2:	8b 4d f0             	mov    -0x10(%rbp),%ecx
   5:	eb 09                	jmp    0x10
   7:	6b c0 64             	imul   $0x64,%eax,%eax
   a:	8d b0 10 38 71 45    	lea    0x45713810(%rax),%esi
  10:	8a 5e 60             	mov    0x60(%rsi),%bl
  13:	b8                   	.byte 0xb8
  14:	ff 1f                	lcall  *(%rdi)
[    4.181613][    T1] EAX: 00000016 EBX: 00080000 ECX: 00000000 EDX: 00000000
[    4.181613][    T1] ESI: 00000000 EDI: 403e0610 EBP: 40397ad0 ESP: 40397a30
[    4.181613][    T1] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 EFLAGS: 00010016
[    4.181613][    T1] CR0: 80050033 CR2: 00000000 CR3: 05654000 CR4: 00000690
[    4.181613][    T1] Call Trace:
[ 4.181613][ T1] ? __lock_acquire (lockdep.c:?) 
[ 4.181613][ T1] ? update_cfs_rq_load_avg (fair.c:?) 
[ 4.181613][ T1] ? lock_acquire (??:?) 
[ 4.181613][ T1] ? ___slab_alloc (slub.c:?) 
[ 4.181613][ T1] ? _raw_spin_lock_irqsave (??:?) 
[ 4.181613][ T1] ? ___slab_alloc (slub.c:?) 
[ 4.181613][ T1] ? __cond_resched (??:?) 
[ 4.181613][ T1] ? slab_pre_alloc_hook (slub.c:?) 
[ 4.181613][ T1] ? kmem_cache_alloc (??:?) 
[ 4.181613][ T1] ? mempool_alloc_slab (??:?) 
[ 4.181613][ T1] ? mempool_init_node (??:?) 
[ 4.181613][ T1] ? mempool_init (??:?) 
[ 4.181613][ T1] ? mempool_alloc_slab (??:?) 
[ 4.181613][ T1] ? bioset_init (??:?) 
[ 4.181613][ T1] ? mempool_alloc_slab (??:?) 
[ 4.181613][ T1] ? init_bio (bio.c:?) 
[ 4.181613][ T1] ? blkdev_init (bio.c:?) 
[ 4.181613][ T1] ? do_one_initcall (??:?) 
[ 4.181613][ T1] ? blkdev_init (bio.c:?) 
[ 4.181613][ T1] ? do_initcall_level (main.c:?) 
[ 4.181613][ T1] ? do_initcalls (main.c:?) 
[ 4.181613][ T1] ? do_basic_setup (main.c:?) 
[ 4.181613][ T1] ? kernel_init_freeable (main.c:?) 
[ 4.181613][ T1] ? rest_init (main.c:?) 
[ 4.181613][ T1] ? kernel_init (main.c:?) 
[ 4.181613][ T1] ? rest_init (main.c:?) 
[ 4.181613][ T1] ? ret_from_fork (??:?) 
[    4.181613][    T1] irq event stamp: 52976
[ 4.181613][ T1] hardirqs last enabled at (52975): __schedule (core.c:?) 
[ 4.181613][ T1] hardirqs last disabled at (52976): _raw_spin_lock_irqsave (??:?) 
[ 4.181613][ T1] softirqs last enabled at (52954): __do_softirq (??:?) 
[ 4.181613][ T1] softirqs last disabled at (52949): do_softirq_own_stack (??:?) 
[    4.181613][    T1] ---[ end trace 0000000000000000 ]---


To reproduce:

        # build kernel
	cd linux
	cp config-6.1.0-rc1-00012-g216fd003b5ac .config
	make HOSTCC=clang-14 CC=clang-14 ARCH=i386 olddefconfig prepare modules_prepare bzImage modules
	make HOSTCC=clang-14 CC=clang-14 ARCH=i386 INSTALL_MOD_PATH=<mod-install-dir> modules_install
	cd <mod-install-dir>
	find lib/ | cpio -o -H newc --quiet | gzip > modules.cgz


        git clone https://github.com/intel/lkp-tests.git
        cd lkp-tests
        bin/lkp qemu -k <bzImage> -m modules.cgz job-script # job-script is attached in this email

        # if come across any failure that blocks the test,
        # please remove ~/.lkp and /lkp dir to run from a clean state.



-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



View attachment "config-6.1.0-rc1-00012-g216fd003b5ac" of type "text/plain" (159403 bytes)

View attachment "job-script" of type "text/plain" (4892 bytes)

Download attachment "dmesg.xz" of type "application/x-xz" (11516 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ