linux-kernel - [PATCH] usb: add NO_LPM quirk for Realforce 87U Keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221027082208.25483-1-ndumazet@google.com>
Date:   Thu, 27 Oct 2022 10:22:08 +0200
From:   Nicolas Dumazet <ndumazet@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jean-Francois Le Fillatre <jflf_kernel@....com>
Cc:     Petar Kostic <petar@...tic.dev>, Oliver Neukum <oneukum@...e.com>,
        Ole Ernst <olebowle@....com>,
        Hannu Hartikainen <hannu@...k.in>,
        Jimmy Wang <wangjm221@...il.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nicolas Dumazet <ndumazet@...gle.com>, stable@...r.kernel.org
Subject: [PATCH] usb: add NO_LPM quirk for Realforce 87U Keyboard

Before adding this quirk, this (mechanical keyboard) device would not be
recognized, logging:

  new full-speed USB device number 56 using xhci_hcd
  unable to read config index 0 descriptor/start: -32
  chopping to 0 config(s)

It would take dozens of plugging/unpuggling cycles for the keyboard to
be recognized. Keyboard seems to simply work after applying this quirk.

This issue had been reported by users in two places already ([1], [2])
but nobody tried upstreaming a patch yet. After testing I believe their
suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a
little overkill. I assume this particular combination was tested because
it had been previously suggested in [3], but only NO_LPM seems
sufficient for this device.

[1]: https://qiita.com/float168/items/fed43d540c8e2201b543
[2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/
[3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477

Cc: stable@...r.kernel.org
Signed-off-by: Nicolas Dumazet <ndumazet@...gle.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0722d2131305..e775d1bbea4d 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -532,6 +532,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* INTEL VALUE SSD */
 	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Realforce 87U Keyboard */
+	{ USB_DEVICE(0x0853, 0x011b), .driver_info = USB_QUIRK_NO_LPM },
+
 	{ }  /* terminating entry must be last */
 };
 
-- 
2.38.0.135.g90850a2211-goog