linux-kernel - Re: [PATCH v4 08/16] x86/mtrr: remove set_all callback from struct mtrr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1pM05I7I4HBpIcw@zn.tnic>
Date:   Thu, 27 Oct 2022 11:18:11 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v4 08/16] x86/mtrr: remove set_all callback from struct
 mtrr_ops

On Tue, Oct 04, 2022 at 10:10:15AM +0200, Juergen Gross wrote:
> diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c
> index dacb537da126..501ca1747d55 100644
> --- a/arch/x86/kernel/cpu/mtrr/mtrr.c
> +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c
> @@ -165,15 +165,15 @@ static int mtrr_rendezvous_handler(void *info)
>  	 * saved, and we want to replicate that across all the cpus that come
>  	 * online (either at the end of boot or resume or during a runtime cpu
>  	 * online). If we're doing that, @reg is set to something special and on
> -	 * all the cpu's we do mtrr_if->set_all() (On the logical cpu that
> +	 * all the cpu's we do cache_cpu_init() (On the logical cpu that

s/cpu's/CPUs/
s/cpu/CPU/

while at it.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette