[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202210271954.tUprdt0m-lkp@intel.com>
Date: Thu, 27 Oct 2022 19:52:31 +0800
From: kernel test robot <lkp@...el.com>
To: Jingbo Xu <jefflexu@...ux.alibaba.com>, dhowells@...hat.com,
jlayton@...nel.org, linux-cachefs@...hat.com,
linux-erofs@...ts.ozlabs.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-cifs@...r.kernel.org,
linux-nfs@...r.kernel.org, linux-afs@...ts.infradead.org,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] fscache,netfs: move "fscache_" prefixed structures
to fscache.h
Hi Jingbo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on xiang-erofs/dev-test]
[also build test ERROR on trondmy-nfs/linux-next cifs/for-next linus/master v6.1-rc2 next-20221027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jingbo-Xu/fscache-netfs-decouple-raw-fscache-APIs-from-libnetfs/20221027-163946
base: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
patch link: https://lore.kernel.org/r/20221027083547.46933-10-jefflexu%40linux.alibaba.com
patch subject: [PATCH 9/9] fscache,netfs: move "fscache_" prefixed structures to fscache.h
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/a3c5c0f70f13603ed27cc7f5245981eb46dad405
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jingbo-Xu/fscache-netfs-decouple-raw-fscache-APIs-from-libnetfs/20221027-163946
git checkout a3c5c0f70f13603ed27cc7f5245981eb46dad405
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash fs/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
fs/fscache/stats.c: In function 'fscache_stats_show':
>> fs/fscache/stats.c:100:9: error: implicit declaration of function 'netfs_stats_show' [-Werror=implicit-function-declaration]
100 | netfs_stats_show(m);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/netfs_stats_show +100 fs/fscache/stats.c
8e7a867bb7309fb David Howells 2021-10-20 51
1e1236b841166f1 David Howells 2021-10-20 52 /*
1e1236b841166f1 David Howells 2021-10-20 53 * display the general statistics
1e1236b841166f1 David Howells 2021-10-20 54 */
1e1236b841166f1 David Howells 2021-10-20 55 int fscache_stats_show(struct seq_file *m, void *v)
1e1236b841166f1 David Howells 2021-10-20 56 {
1e1236b841166f1 David Howells 2021-10-20 57 seq_puts(m, "FS-Cache statistics\n");
7f3283aba39a0f3 David Howells 2021-10-20 58 seq_printf(m, "Cookies: n=%d v=%d vcol=%u voom=%u\n",
7f3283aba39a0f3 David Howells 2021-10-20 59 atomic_read(&fscache_n_cookies),
62ab63352350e88 David Howells 2021-10-20 60 atomic_read(&fscache_n_volumes),
62ab63352350e88 David Howells 2021-10-20 61 atomic_read(&fscache_n_volumes_collision),
62ab63352350e88 David Howells 2021-10-20 62 atomic_read(&fscache_n_volumes_nomem)
62ab63352350e88 David Howells 2021-10-20 63 );
1e1236b841166f1 David Howells 2021-10-20 64
7f3283aba39a0f3 David Howells 2021-10-20 65 seq_printf(m, "Acquire: n=%u ok=%u oom=%u\n",
7f3283aba39a0f3 David Howells 2021-10-20 66 atomic_read(&fscache_n_acquires),
7f3283aba39a0f3 David Howells 2021-10-20 67 atomic_read(&fscache_n_acquires_ok),
7f3283aba39a0f3 David Howells 2021-10-20 68 atomic_read(&fscache_n_acquires_oom));
7f3283aba39a0f3 David Howells 2021-10-20 69
12bb21a29c19aae David Howells 2021-10-20 70 seq_printf(m, "LRU : n=%u exp=%u rmv=%u drp=%u at=%ld\n",
12bb21a29c19aae David Howells 2021-10-20 71 atomic_read(&fscache_n_cookies_lru),
12bb21a29c19aae David Howells 2021-10-20 72 atomic_read(&fscache_n_cookies_lru_expired),
12bb21a29c19aae David Howells 2021-10-20 73 atomic_read(&fscache_n_cookies_lru_removed),
12bb21a29c19aae David Howells 2021-10-20 74 atomic_read(&fscache_n_cookies_lru_dropped),
12bb21a29c19aae David Howells 2021-10-20 75 timer_pending(&fscache_cookie_lru_timer) ?
12bb21a29c19aae David Howells 2021-10-20 76 fscache_cookie_lru_timer.expires - jiffies : 0);
12bb21a29c19aae David Howells 2021-10-20 77
d24af13e2e2358a David Howells 2021-10-20 78 seq_printf(m, "Invals : n=%u\n",
d24af13e2e2358a David Howells 2021-10-20 79 atomic_read(&fscache_n_invalidates));
d24af13e2e2358a David Howells 2021-10-20 80
16a96bdf92d5af0 David Howells 2021-10-20 81 seq_printf(m, "Updates: n=%u rsz=%u rsn=%u\n",
16a96bdf92d5af0 David Howells 2021-10-20 82 atomic_read(&fscache_n_updates),
16a96bdf92d5af0 David Howells 2021-10-20 83 atomic_read(&fscache_n_resizes),
16a96bdf92d5af0 David Howells 2021-10-20 84 atomic_read(&fscache_n_resizes_null));
7f3283aba39a0f3 David Howells 2021-10-20 85
7f3283aba39a0f3 David Howells 2021-10-20 86 seq_printf(m, "Relinqs: n=%u rtr=%u drop=%u\n",
7f3283aba39a0f3 David Howells 2021-10-20 87 atomic_read(&fscache_n_relinquishes),
7f3283aba39a0f3 David Howells 2021-10-20 88 atomic_read(&fscache_n_relinquishes_retire),
7f3283aba39a0f3 David Howells 2021-10-20 89 atomic_read(&fscache_n_relinquishes_dropped));
7f3283aba39a0f3 David Howells 2021-10-20 90
9f08ebc3438baaa David Howells 2021-10-22 91 seq_printf(m, "NoSpace: nwr=%u ncr=%u cull=%u\n",
3929eca769b5a23 David Howells 2021-10-21 92 atomic_read(&fscache_n_no_write_space),
9f08ebc3438baaa David Howells 2021-10-22 93 atomic_read(&fscache_n_no_create_space),
9f08ebc3438baaa David Howells 2021-10-22 94 atomic_read(&fscache_n_culled));
3929eca769b5a23 David Howells 2021-10-21 95
8e7a867bb7309fb David Howells 2021-10-20 96 seq_printf(m, "IO : rd=%u wr=%u\n",
8e7a867bb7309fb David Howells 2021-10-20 97 atomic_read(&fscache_n_read),
8e7a867bb7309fb David Howells 2021-10-20 98 atomic_read(&fscache_n_write));
8e7a867bb7309fb David Howells 2021-10-20 99
1e1236b841166f1 David Howells 2021-10-20 @100 netfs_stats_show(m);
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (244073 bytes)
Powered by blists - more mailing lists