[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <35ed0b8f-04f1-d544-a0d8-19d12e7c0ef8@linaro.org>
Date: Thu, 27 Oct 2022 10:59:25 -0400
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Johan Jonker <jbx6244@...il.com>, kever.yang@...k-chips.com,
heiko@...ech.de
Cc: sjg@...omium.org, philipp.tomsich@...ll.eu,
zhangqing@...k-chips.com, hjc@...k-chips.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, daniel.lezcano@...aro.org,
tglx@...utronix.de, arnd@...db.de, olof@...om.net, soc@...nel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v1 4/4] ARM: dts: rockchip: add rk3128-evb.dts
On 26/10/2022 20:54, Johan Jonker wrote:
> Add rk3128-evb.dts
>
> Signed-off-by: Johan Jonker <jbx6244@...il.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/rk3128-evb.dts | 105 +++++++++++++++++++++++++++++++
> 2 files changed, 106 insertions(+)
> create mode 100644 arch/arm/boot/dts/rk3128-evb.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 68ac9b360..0f26539d2 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1127,6 +1127,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
> rk3066a-marsboard.dtb \
> rk3066a-mk808.dtb \
> rk3066a-rayeager.dtb \
> + rk3128-evb.dtb \
> rk3188-bqedison2qc.dtb \
> rk3188-px3-evb.dtb \
> rk3188-radxarock.dtb \
> diff --git a/arch/arm/boot/dts/rk3128-evb.dts b/arch/arm/boot/dts/rk3128-evb.dts
> new file mode 100644
> index 000000000..6ad4549d5
> --- /dev/null
> +++ b/arch/arm/boot/dts/rk3128-evb.dts
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2017 Rockchip Electronics Co., Ltd
> + */
> +
> +/dts-v1/;
> +
> +#include "rk3128.dtsi"
> +
> +/ {
> + model = "Rockchip RK3128 Evaluation board";
> + compatible = "rockchip,rk3128-evb", "rockchip,rk3128";
> +
> + aliases {
> + mmc0 = &emmc;
> + };
> +
> + chosen {
> + stdout-path = &uart2;
> + };
> +
> + memory@...00000 {
> + device_type = "memory";
> + reg = <0x60000000 0x40000000>;
> + };
> +
> + vcc5v0_otg: vcc5v0-otg-drv {
Generic node names, so at least regulator prefix or suffix.
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_otg";
> + gpio = <&gpio0 26 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&otg_vbus_drv>;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> + vcc5v0_host: vcc5v0-host-drv {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_host";
> + gpio = <&gpio2 23 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&host_vbus_drv>;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> +};
> +
> +&emmc {
> + bus-width = <8>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +
> + hym8563: rtc@51 {
> + compatible = "haoyu,hym8563";
> + reg = <0x51>;
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + clock-output-names = "xin32k";
> + };
> +};
> +
> +&usb2phy {
> + status = "okay";
> +};
> +
> +&usb2phy_host {
> + status = "okay";
> +};
> +
> +&usb2phy_otg {
> + status = "okay";
> +};
> +
> +&usb_host_ehci {
> + status = "okay";
> +};
> +
> +&usb_host_ohci {
> + status = "okay";
> +};
> +
> +&usb_otg {
> + vbus-supply = <&vcc5v0_otg>;
> + status = "okay";
> +};
> +
> +&pinctrl {
> + usb_otg {
No underscores in node names
> + otg_vbus_drv: otg-vbus-drv {
> + rockchip,pins = <0 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
> + usb_host {
Ditto
> + host_vbus_drv: host-vbus-drv {
> + rockchip,pins = <2 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +};
> --
> 2.20.1
>
Best regards,
Krzysztof
Powered by blists - more mailing lists