linux-kernel - Re: [Internet]Re: [PATCH net-next v2] net: skb: export skb drop reaons to user by TRACE_DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82699D69-00C8-4C0B-BEA2-32284EB63B63@tencent.com>
Date:   Fri, 28 Oct 2022 02:26:02 +0000
From:   imagedong(董梦龙) <imagedong@...cent.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ian Rogers <irogers@...gle.com>
CC:     Menglong Dong <menglong8.dong@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Ingo Molnar <mingo@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        flyingpeng(彭浩) <flyingpeng@...cent.com>,
        Dongli Zhang <dongli.zhang@...cle.com>,
        "robh@...nel.org" <robh@...nel.org>,
        Pavel Begunkov <asml.silence@...il.com>,
        Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
        Vasily Averin <vasily.averin@...ux.dev>,
        LKML <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [Internet]Re: [PATCH net-next v2] net: skb: export skb drop
 reaons to user by TRACE_DEFINE_ENUM

> On 2022/10/28 00:29，“Eric Dumazet”<edumazet@...gle.com> write:
> 
> On Thu, Oct 27, 2022 at 8:43 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > On Thu, 27 Oct 2022 08:32:02 -0700
> > Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > > This seems broken again (tried on latest net-next tree)
> > >
> > > perf script
> >
> > Do you also have the latest perf and the latest libtraceevent installed?
> >
> 
> I tried a more recent perf binary we have, but it is also not right.
> 
> I guess I will have to request a new perf binary at Google :/
> 

Ennn...I just have a try, and it seems fine:

sudo perf script
         swapper     0 [049] 401460.138078: skb:kfree_skb: skbaddr=0xffff8881076d2400 protocol=2048 location=0xffffffff81d86546 reason: TCP_INVALID_SEQUENCE
              nc 429418 [006] 401465.652282: skb:kfree_skb: skbaddr=0xffff8881ea66cf00 protocol=0 location=0xffffffff81e0b48f reason: NOT_SPECIFIED
              nc 429418 [006] 401465.652293: skb:kfree_skb: skbaddr=0xffff8881ea66cf00 protocol=0 location=0xffffffff81e0b48f reason: NOT_SPECIFIED
              nc 429418 [006] 401465.652538: skb:kfree_skb: skbaddr=0xffff888133c014e8 protocol=2048 location=0xffffffff81d983a1 reason: NO_SOCKET

The version of the perf I used is 6.0.3-1:

  sudo apt info linux-perf
  Package: linux-perf
  Version: 6.0.3-1


Thanks!
Menglong Dong

> perf5 script
>          swapper     0 [030]  4147.704606: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4147.704615: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4148.048173: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4148.048179: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [008]  4148.048773: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4148.112271: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4148.112280: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4148.720149: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4148.720155: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4149.072141: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4149.072149: skb:kfree_skb: [UNKNOWN EVENT]