linux-kernel - Re: [PATCH] random: Use arch_get_random*_early() in random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1v/ZkT4nOrKI2Y9@zx2c4.com>
Date:   Fri, 28 Oct 2022 18:12:22 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Jean-Philippe Brucker <jean-philippe@...aro.org>
Cc:     tytso@....edu, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, ardb@...nel.org,
        andre.przywara@....com
Subject: Re: [PATCH] random: Use arch_get_random*_early() in random_init()

On Fri, Oct 28, 2022 at 05:00:42PM +0100, Jean-Philippe Brucker wrote:
> While reworking the archrandom handling, commit d349ab99eec7 ("random:
> handle archrandom with multiple longs") switched to the non-early
> archrandom helpers in random_init(), which broke initialization of the
> entropy pool from the arm64 random generator.
> 
> Indeed at that point the arm64 CPU features, which verify that all CPUs
> have compatible capabilities, are not finalized so arch_get_random_seed_longs()
> is unsuccessful. Instead random_init() should use the _early functions,
> which check only the boot CPU on arm64. On other architectures the
> _early functions directly call the normal ones.
> 
> Fixes: d349ab99eec7 ("random: handle archrandom with multiple longs")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@...aro.org>

Thank you for catching this. I'll get this queued up for the next rc.

Jason