linux-kernel - Re: [PATCH] ACPI: processor_throttling: remove variable count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jJPHrfUpY4ZxJYhNR334XZC_iUvetYgRGZW+iLgGrUzg@mail.gmail.com>
Date:   Fri, 28 Oct 2022 19:03:49 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: processor_throttling: remove variable count

On Mon, Oct 24, 2022 at 3:33 PM Colin Ian King <colin.i.king@...il.com> wrote:
>
> Variable count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/acpi/processor_throttling.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
> index a822fe410dda..00d045e5f524 100644
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -50,7 +50,7 @@ static int __acpi_processor_set_throttling(struct acpi_processor *pr,
>
>  static int acpi_processor_update_tsd_coord(void)
>  {
> -       int count, count_target;
> +       int count_target;
>         int retval = 0;
>         unsigned int i, j;
>         cpumask_var_t covered_cpus;
> @@ -107,7 +107,6 @@ static int acpi_processor_update_tsd_coord(void)
>
>                 /* Validate the Domain info */
>                 count_target = pdomain->num_processors;
> -               count = 1;
>
>                 for_each_possible_cpu(j) {
>                         if (i == j)
> @@ -140,7 +139,6 @@ static int acpi_processor_update_tsd_coord(void)
>
>                         cpumask_set_cpu(j, covered_cpus);
>                         cpumask_set_cpu(j, pthrottling->shared_cpu_map);
> -                       count++;
>                 }
>                 for_each_possible_cpu(j) {
>                         if (i == j)
> --

Applied as 6.2 material, thanks!