[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221028172203.GD13880@thinkpad>
Date: Fri, 28 Oct 2022 22:52:03 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Qiang Yu <quic_qianyu@...cinc.com>
Cc: quic_hemantk@...cinc.com, loic.poulain@...aro.org,
mhi@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, quic_cang@...cinc.com,
mrana@...cinc.com
Subject: Re: [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of
register write
On Mon, Oct 10, 2022 at 12:32:04PM +0800, Qiang Yu wrote:
> Currently, a direct register write is used when ramdump collection
> in panic path occurs. Replace that with new mhi_soc_reset() API
> such that a controller defined reset() function is exercised if
> one is present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Qiang Yu <quic_qianyu@...cinc.com>
> Reviewed-by: Loic Poulain <loic.poulain@...aro.org>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>
Btw, this patch is supposed to be v2... Please keep the version info and also
add the changelog for future patches.
Thanks,
Mani
> ---
> drivers/bus/mhi/host/boot.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index 26d0edd..1c69fee 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> /* Hardware reset so force device to enter RDDM */
> dev_dbg(dev,
> "Did not enter RDDM, do a host req reset\n");
> - mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
> - MHI_SOC_RESET_REQ_OFFSET,
> - MHI_SOC_RESET_REQ);
> + mhi_soc_reset(mhi_cntrl);
> udelay(delayus);
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists