linux-kernel - Re: [PATCH 1/2] cpuidle: dt: Return the correct numbers of parsed idle states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hQj2OgpCj-6REuCYwMn+qoHc1TXQ+HjtqL8JcL8XPQRg@mail.gmail.com>
Date:   Fri, 28 Oct 2022 20:10:23 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Sudeep Holla <sudeep.holla@....com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-pm@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cpuidle: dt: Return the correct numbers of parsed
 idle states

On Tue, Oct 25, 2022 at 1:43 PM Sudeep Holla <sudeep.holla@....com> wrote:
>
> On Fri, Oct 21, 2022 at 05:10:12PM +0200, Ulf Hansson wrote:
> > While we correctly skips to initialize an idle state from a disabled idle
> > state node in DT, the returned value from dt_init_idle_driver() don't get
> > adjusted accordingly. Instead the number of found idle state nodes are
> > returned, while the callers are expecting the number of successfully
> > initialized idle states from DT.
> >
> > This leads to cpuidle drivers unnecessarily continues to initialize their
> > idle state specific data. Moreover, in the case when all idle states have
> > been disabled in DT, we would end up registering a cpuidle driver, rather
> > than relying on the default arch specific idle call.
> >
>
> Makes sense.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>

Applied along with the [2/2] as 6.2 material, thanks!