[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221028193945.GA2192436-robh@kernel.org>
Date: Fri, 28 Oct 2022 14:39:45 -0500
From: Rob Herring <robh@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Mark Brown <broonie@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Banajit Goswami <bgoswami@...cinc.com>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] ASoC: dt-bindings: wcd938x: fix codec reset line
polarity in example
On Thu, Oct 27, 2022 at 12:46:52AM -0700, Dmitry Torokhov wrote:
> The driver for the codec, when resetting the chip, first drives the line
> low, and then high. This means that the line is active low. Change the
> annotation in the example DTS accordingly.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
> Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> index 51547190f709..2f5e0df93872 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> @@ -112,7 +112,7 @@ examples:
> - |
> codec {
> compatible = "qcom,wcd9380-codec";
> - reset-gpios = <&tlmm 32 0>;
> + reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;
Missing a header for this.
> #sound-dai-cells = <1>;
> qcom,tx-device = <&wcd938x_tx>;
> qcom,rx-device = <&wcd938x_rx>;
> --
> 2.38.0.135.g90850a2211-goog
>
>
Powered by blists - more mailing lists