linux-kernel - Re: [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 15:34:43 -0500
From:   Eric DeVolder <eric.devolder@...cle.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Baoquan He <bhe@...hat.com>, david@...hat.com,
        Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        kexec@...ts.infradead.org, ebiederm@...ssion.com,
        dyoung@...hat.com, vgoyal@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, dave.hansen@...ux.intel.com, hpa@...or.com,
        nramas@...ux.microsoft.com, thomas.lendacky@....com,
        robh@...nel.org, efault@....de, rppt@...nel.org,
        sourabhjain@...ux.ibm.com, linux-mm@...ck.org
Subject: Re: [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support



On 10/28/22 15:30, Borislav Petkov wrote:
> On Fri, Oct 28, 2022 at 02:26:58PM -0500, Eric DeVolder wrote:
>> config CRASH_MAX_MEMORY_RANGES
>>      depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG
>>      int
>>      default 8192
>>      help
>>        For the kexec_file_load path, specify the maximum number of
>>        memory regions, eg. as represented by the 'System RAM' entries
>>        in /proc/iomem, that the elfcorehdr buffer/segment can accommodate.
>>        This value is combined with NR_CPUS and multiplied by Elf64_Phdr
>>        size to determine the final buffer size.
> 
> No, do this:
> 
> config CRASH_MEMORY_HOTPLUG_SUPPORT
>      depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG
>      help
>        Help text explaining what this feature is
> 
> this thing will simply get enabled when the user enables MEMORY_HOTPLUG
> and CRASH_DUMP.
> 
> and then you do in the code:
> 
> /*
>   * A comment explaining how the 8192 value has been selected.
>   */
> #define CRASH_MAX_MEMORY_RANGES	8192
> 
> Thx.
> 
ok, will do!
thanks!
eric