linux-kernel - Re: [PATCH v3 12/17] ufs: core: mcq: Find hardware queue to queue request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <817ec99a-b28e-6fb7-383d-f8a3ac578686@acm.org>
Date:   Fri, 28 Oct 2022 14:53:01 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Asutosh Das <quic_asutoshd@...cinc.com>, quic_cang@...cinc.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org
Cc:     quic_nguyenb@...cinc.com, quic_xiaosenh@...cinc.com,
        stanley.chu@...iatek.com, eddie.huang@...iatek.com,
        daejun7.park@...sung.com, avri.altman@....com, mani@...nel.org,
        beanhuo@...ron.com, quic_richardp@...cinc.com,
        linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 12/17] ufs: core: mcq: Find hardware queue to queue
 request

On 10/20/22 11:03, Asutosh Das wrote:
> +struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba,
> +					 struct request *req)
> +{
> +	u32 utag, hwq;
> +
> +	utag = blk_mq_unique_tag(req);
> +	hwq = blk_mq_unique_tag_to_hwq(utag);

A minor stylistic nit: please combine declaration and assignment as follows:

         u32 utag = blk_mq_unique_tag(req);
         u32 hwq = blk_mq_unique_tag_to_hwq(utag);

> +	/* uhq[0] is to serve device commands */

is -> is used?

> +	return &hba->uhq[hwq + UFSHCD_MCQ_IO_QUEUE_OFFSET];

Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@....org>