linux-kernel - Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1tTLAEi7ukUCCmB@gondor.apana.org.au>
Date:   Fri, 28 Oct 2022 11:57:32 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     liulongfang <liulongfang@...wei.com>
Cc:     wangzhou1@...ilicon.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto/hisilicon: Add null judgment to the callback
 interface

On Fri, Sep 30, 2022 at 11:48:02AM +0800, liulongfang wrote:
>
> Even if the task is sent in synchronous mode, when using the hardware
> driver, the hardware still informs the driver software through an
> interrupt after completing the task, and the workqueue in the driver
> software will call this callback function.
> 
> And I found that the device drivers of other manufacturers under the
> crypto subsystem are also in this asynchronous mode, and this problem
> is also encountered when using the synchronous mode.

This still makes no sense to me.

Who is making an async request with no callback?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt