linux-kernel - Re: [PATCH v6 3/3] clk: Add Ingenic JZ4755 CGU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKNVLfaA20jO0HMDMU28e-96HaQEAZ5At_vqQU+Ni_tEEt84gQ@mail.gmail.com>
Date:   Fri, 28 Oct 2022 07:39:08 +0300
From:   Siarhei Volkau <lis8215@...il.com>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Paul Cercueil <paul@...pouillou.net>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v6 3/3] clk: Add Ingenic JZ4755 CGU driver

пт, 28 окт. 2022 г. в 00:57, Stephen Boyd <sboyd@...nel.org>:
>
> Quoting Siarhei Volkau (2022-10-27 12:20:23)
> > diff --git a/drivers/clk/ingenic/jz4755-cgu.c b/drivers/clk/ingenic/jz4755-cgu.c
> > new file mode 100644
> > index 000000000..d2eb3ae0c
> > --- /dev/null
> > +++ b/drivers/clk/ingenic/jz4755-cgu.c
> > @@ -0,0 +1,346 @@
> [...]
> > +static void __init jz4755_cgu_init(struct device_node *np)
> > +{
> > +       int retval;
> > +
> > +       cgu = ingenic_cgu_new(jz4755_cgu_clocks,
> > +                             ARRAY_SIZE(jz4755_cgu_clocks), np);
> > +       if (!cgu) {
> > +               pr_err("%s: failed to initialise CGU\n", __func__);
> > +               return;
> > +       }
> > +
> > +       retval = ingenic_cgu_register_clocks(cgu);
> > +       if (retval)
> > +               pr_err("%s: failed to register CGU Clocks\n", __func__);
> > +
> > +       ingenic_cgu_register_syscore_ops(cgu);
> > +}
> > +CLK_OF_DECLARE_DRIVER(jz4755_cgu, "ingenic,jz4755-cgu", jz4755_cgu_init);
>
> Is there another driver that probes this device? CLK_OF_DECLARE_DRIVER()
> is for the situation where we want to probe this device again with
> another platform driver. Please add a comment indicating what that other
> driver is.

I wasn't aware of that, it's just
> + * Heavily based on JZ4725b CGU driver
with no comment either, same as a few others.
Maybe it's better to fix that in a separate commit as per Paul's
proposal on unused macros'?