| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Oct 2022 14:16:01 +0800
From: kernel test robot <lkp@...el.com>
To: Steen Hegelund <steen.hegelund@...rochip.com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev,
Steen Hegelund <steen.hegelund@...rochip.com>,
UNGLinuxDriver@...rochip.com, Randy Dunlap <rdunlap@...radead.org>,
Casper Andersson <casper.casan@...il.com>,
Russell King <rmk+kernel@...linux.org.uk>,
Wan Jiabing <wanjiabing@...o.com>,
Nathan Huckleberry <nhuck@...gle.com>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Daniel Machon <daniel.machon@...rochip.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
Lars Povlsen <lars.povlsen@...rochip.com>
Subject: Re: [PATCH net-next 5/5] net: microchip: sparx5: Adding KUNIT tests
of key/action values in VCAP API
Hi Steen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Steen-Hegelund/Extend-TC-key-support-for-Sparx5-IS2-VCAP/20221027-224601
patch link: https://lore.kernel.org/r/20221027144300.2936955-6-steen.hegelund%40microchip.com
patch subject: [PATCH net-next 5/5] net: microchip: sparx5: Adding KUNIT tests of key/action values in VCAP API
config: arc-allyesconfig
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f0ff9cf2861b1ca24e211d11a2c46f035e9467c8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Steen-Hegelund/Extend-TC-key-support-for-Sparx5-IS2-VCAP/20221027-224601
git checkout f0ff9cf2861b1ca24e211d11a2c46f035e9467c8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/net/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/microchip/vcap/vcap_api.c:1410:
drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c: In function 'vcap_api_rule_find_keyset_test':
>> drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c:1169:1: warning: the frame size of 1412 bytes is larger than 1024 bytes [-Wframe-larger-than=]
1169 | }
| ^
vim +1169 drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c
1063
1064 static void vcap_api_rule_find_keyset_test(struct kunit *test)
1065 {
1066 struct vcap_keyset_list matches = {};
1067 struct vcap_admin admin = {
1068 .vtype = VCAP_TYPE_IS2,
1069 };
1070 struct vcap_rule_internal ri = {
1071 .admin = &admin,
1072 .vctrl = &test_vctrl,
1073 };
1074 struct vcap_client_keyfield ckf_1[] = {
1075 {
1076 .ctrl.key = VCAP_KF_TYPE,
1077 }, {
1078 .ctrl.key = VCAP_KF_LOOKUP_FIRST_IS,
1079 }, {
1080 .ctrl.key = VCAP_KF_IF_IGR_PORT_MASK_L3,
1081 }, {
1082 .ctrl.key = VCAP_KF_IF_IGR_PORT_MASK_RNG,
1083 }, {
1084 .ctrl.key = VCAP_KF_IF_IGR_PORT_MASK,
1085 }, {
1086 .ctrl.key = VCAP_KF_L2_DMAC,
1087 }, {
1088 .ctrl.key = VCAP_KF_ETYPE_LEN_IS,
1089 }, {
1090 .ctrl.key = VCAP_KF_ETYPE,
1091 },
1092 };
1093 struct vcap_client_keyfield ckf_2[] = {
1094 {
1095 .ctrl.key = VCAP_KF_TYPE,
1096 }, {
1097 .ctrl.key = VCAP_KF_LOOKUP_FIRST_IS,
1098 }, {
1099 .ctrl.key = VCAP_KF_ARP_OPCODE,
1100 }, {
1101 .ctrl.key = VCAP_KF_L3_IP4_SIP,
1102 }, {
1103 .ctrl.key = VCAP_KF_L3_IP4_DIP,
1104 }, {
1105 .ctrl.key = VCAP_KF_8021Q_PCP_CLS,
1106 }, {
1107 .ctrl.key = VCAP_KF_ETYPE_LEN_IS, /* Not with ARP */
1108 }, {
1109 .ctrl.key = VCAP_KF_ETYPE, /* Not with ARP */
1110 },
1111 };
1112 struct vcap_client_keyfield ckf_3[] = {
1113 {
1114 .ctrl.key = VCAP_KF_TYPE,
1115 }, {
1116 .ctrl.key = VCAP_KF_LOOKUP_FIRST_IS,
1117 }, {
1118 .ctrl.key = VCAP_KF_8021Q_DEI_CLS,
1119 }, {
1120 .ctrl.key = VCAP_KF_8021Q_PCP_CLS,
1121 }, {
1122 .ctrl.key = VCAP_KF_8021Q_VID_CLS,
1123 }, {
1124 .ctrl.key = VCAP_KF_ISDX_CLS,
1125 }, {
1126 .ctrl.key = VCAP_KF_L2_MC_IS,
1127 }, {
1128 .ctrl.key = VCAP_KF_L2_BC_IS,
1129 },
1130 };
1131 int idx;
1132 bool ret;
1133 enum vcap_keyfield_set keysets[10] = {0};
1134
1135 INIT_LIST_HEAD(&ri.data.keyfields);
1136 for (idx = 0; idx < ARRAY_SIZE(ckf_1); idx++)
1137 list_add_tail(&ckf_1[idx].ctrl.list, &ri.data.keyfields);
1138 matches.keysets = keysets;
1139 matches.max = ARRAY_SIZE(keysets);
1140 memset(keysets, 0, sizeof(keysets));
1141
1142 ret = vcap_rule_find_keysets(&ri, &matches);
1143 KUNIT_EXPECT_EQ(test, true, ret);
1144 KUNIT_EXPECT_EQ(test, 1, matches.cnt);
1145 KUNIT_EXPECT_EQ(test, VCAP_KFS_MAC_ETYPE, matches.keysets[0]);
1146
1147 INIT_LIST_HEAD(&ri.data.keyfields);
1148 for (idx = 0; idx < ARRAY_SIZE(ckf_2); idx++)
1149 list_add_tail(&ckf_2[idx].ctrl.list, &ri.data.keyfields);
1150 memset(keysets, 0, sizeof(keysets));
1151 ret = vcap_rule_find_keysets(&ri, &matches);
1152 KUNIT_EXPECT_EQ(test, false, ret);
1153 KUNIT_EXPECT_EQ(test, 0, matches.cnt);
1154 KUNIT_EXPECT_EQ(test, VCAP_KFS_NO_VALUE, matches.keysets[0]);
1155
1156 INIT_LIST_HEAD(&ri.data.keyfields);
1157 for (idx = 0; idx < ARRAY_SIZE(ckf_3); idx++)
1158 list_add_tail(&ckf_3[idx].ctrl.list, &ri.data.keyfields);
1159 memset(keysets, 0, sizeof(keysets));
1160 ret = vcap_rule_find_keysets(&ri, &matches);
1161 KUNIT_EXPECT_EQ(test, true, ret);
1162 KUNIT_EXPECT_EQ(test, 6, matches.cnt);
1163 KUNIT_EXPECT_EQ(test, VCAP_KFS_ARP, matches.keysets[0]);
1164 KUNIT_EXPECT_EQ(test, VCAP_KFS_IP4_OTHER, matches.keysets[1]);
1165 KUNIT_EXPECT_EQ(test, VCAP_KFS_IP4_TCP_UDP, matches.keysets[2]);
1166 KUNIT_EXPECT_EQ(test, VCAP_KFS_IP6_STD, matches.keysets[3]);
1167 KUNIT_EXPECT_EQ(test, VCAP_KFS_IP_7TUPLE, matches.keysets[4]);
1168 KUNIT_EXPECT_EQ(test, VCAP_KFS_MAC_ETYPE, matches.keysets[5]);
> 1169 }
1170
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (317248 bytes)
Powered by blists - more mailing lists