linux-kernel - Re: [PATCH] Possible repeated word: 'very'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1uHl4di6R0pFA/i@debian.me>
Date:   Fri, 28 Oct 2022 14:41:11 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     UMWARI JOVIAL <umwarijovial@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH]  Possible repeated word: 'very'

On Fri, Oct 28, 2022 at 10:04:39AM +0300, UMWARI JOVIAL wrote:
> Reported By checkpatch.pl script
> 
> WARNING: Possible repeated word: 'very'
> 
> Repetition of the same word in one sentence same line
> 
> Signed-off-by: UMWARI JOVIAL <umwarijovial@...il.com>
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index 090345bad223..30a0276b8b58 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
>   * If we turn on USE_RXTHREAD, then, no need for critical section.
>   * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
>   *
> - * Must be very very cautious...
> + * Must be very cautious...
>   *
>   */
>  struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)

NAK!

You send patch with the same content as [1], for which Greg already replied
as [2].

The code and its comments imply that calling r8712_alloc_xmitframe() must be
done with extreme caution, isn't it?

Thanks.

[1]: https://lore.kernel.org/lkml/20221028051420.GA30073@rdm/
[2]: https://lore.kernel.org/lkml/Y1tx8XjmR5QKV9lQ@kroah.com/
-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)