linux-kernel - Re: [PATCH v6 2/2] arm64: dts: qcom: add SA8540P ride(Qdrive-3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221028075059.GA15101@hu-ppareek-blr.qualcomm.com>
Date:   Fri, 28 Oct 2022 13:20:59 +0530
From:   Parikshit Pareek <quic_ppareek@...cinc.com>
To:     <konrad.dybcio@...ainline.org>
CC:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Andrew Halaney <ahalaney@...hat.com>,
        Shazad Hussain <quic_shazhuss@...cinc.com>,
        "Brian Masney" <bmasney@...hat.com>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: add SA8540P ride(Qdrive-3)

On Thu, Oct 20, 2022 at 01:49:23PM +0200, konrad.dybcio@...ainline.org wrote:
> On 2022-10-20 09:30, Parikshit Pareek wrote:
> > Introduce the Qualcomm SA8540P ride automotive platform, also known as
> > Qdrive-3 development board.
> > 
> > This initial contribution supports SMP, CPUFreq, cluster idle, UFS, RPMh
> > regulators, debug UART, PMICs, remoteprocs and USB.
> > 
> > The SA8540P ride contains four PM8450 PMICs.
> > 
> > Signed-off-by: Parikshit Pareek <quic_ppareek@...cinc.com>
> > ---
> 
> Hi!
> 
> [...[
> 
> > +		vreg_l3c: ldo3 {
> > +			regulator-name = "vreg_l3c";
> > +			regulator-min-microvolt = <1200000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > +			regulator-allow-set-load;
> Not sure if setting load is desired after recent rpmh regulator changes.
May I know the exact patch being refered here?
> 
> [...]
> 
> > +
> > +&spmi_bus {
> > +	pm8450a: pmic@0 {
> > +		compatible = "qcom,pm8150", "qcom,spmi-pmic";
> Please add a pm8450[aceg].dtsi instead, as other boards would probably like
> to
> reuse this. Also, move the spmi.h inclusion there.
> 
> [...]
> 
> > +};
> > +
> > +/* PINCTRL */
> Not sure if it's useful if there's nothing there for now.
> 
> Konrad

Regards,
Parikshit Pareek