linux-kernel - Re: [PATCH v3 10/36] net/tcp: Calculate TCP-AO traffic keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210281515.vs5LCjP9-lkp@intel.com>
Date:   Fri, 28 Oct 2022 16:07:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     oe-kbuild-all@...ts.linux.dev, Dmitry Safonov <dima@...sta.com>,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        Dan Carpenter <error27@...il.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri@...sta.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Leonard Crestez <cdleonard@...il.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Salam Noureddine <noureddine@...sta.com>,
        Shuah Khan <skhan@...uxfoundation.org>, netdev@...r.kernel.org,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH v3 10/36] net/tcp: Calculate TCP-AO traffic keys

Hi Dmitry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 4dc12f37a8e98e1dca5521c14625c869537b50b6]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20221028-045452
base:   4dc12f37a8e98e1dca5521c14625c869537b50b6
patch link:    https://lore.kernel.org/r/20221027204347.529913-11-dima%40arista.com
patch subject: [PATCH v3 10/36] net/tcp: Calculate TCP-AO traffic keys
config: sparc-allyesconfig
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/980990bf961b835d23f7518aa5af1ee3c742f64d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20221028-045452
        git checkout 980990bf961b835d23f7518aa5af1ee3c742f64d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash net/ipv6/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/ipv6/tcp_ao.c:16:5: warning: no previous prototype for 'tcp_v6_ao_calc_key' [-Wmissing-prototypes]
      16 | int tcp_v6_ao_calc_key(struct tcp_ao_key *mkt, u8 *key,
         |     ^~~~~~~~~~~~~~~~~~
   net/ipv6/tcp_ao.c:56:20: warning: no previous prototype for 'tcp_v6_ao_do_lookup' [-Wmissing-prototypes]
      56 | struct tcp_ao_key *tcp_v6_ao_do_lookup(const struct sock *sk,
         |                    ^~~~~~~~~~~~~~~~~~~


vim +/tcp_v6_ao_calc_key +16 net/ipv6/tcp_ao.c

    15	
  > 16	int tcp_v6_ao_calc_key(struct tcp_ao_key *mkt, u8 *key,
    17			       const struct in6_addr *saddr,
    18			       const struct in6_addr *daddr,
    19			       __be16 sport, __be16 dport,
    20			       __be32 sisn, __be32 disn)
    21	{
    22		struct kdf_input_block {
    23			u8			counter;
    24			u8			label[6];
    25			struct tcp6_ao_context	ctx;
    26			__be16			outlen;
    27		} __packed tmp;
    28	
    29		tmp.counter	= 1;
    30		memcpy(tmp.label, "TCP-AO", 6);
    31		tmp.ctx.saddr	= *saddr;
    32		tmp.ctx.daddr	= *daddr;
    33		tmp.ctx.sport	= sport;
    34		tmp.ctx.dport	= dport;
    35		tmp.ctx.sisn	= sisn;
    36		tmp.ctx.disn	= disn;
    37		tmp.outlen	= htons(tcp_ao_digest_size(mkt) * 8); /* in bits */
    38	
    39		return tcp_ao_calc_traffic_key(mkt, key, &tmp, sizeof(tmp));
    40	}
    41	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322271 bytes)