lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Oct 2022 10:25:09 +0100 From: Jon Hunter <jonathanh@...dia.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Wayne Chang <waynec@...dia.com>, Rob Herring <robh@...nel.org> Cc: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, Thierry Reding <treding@...dia.com>, "thierry.reding@...il.com" <thierry.reding@...il.com>, "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>, Ajay Gupta <ajayg@...dia.com>, "kishon@...com" <kishon@...com>, "vkoul@...nel.org" <vkoul@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "balbi@...nel.org" <balbi@...nel.org>, "mathias.nyman@...el.com" <mathias.nyman@...el.com>, Jui Chang Kuo <jckuo@...dia.com>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sing-Han Chen <singhanc@...dia.com>, "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org> Subject: Re: [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding On 28/10/2022 03:19, Krzysztof Kozlowski wrote: > On 25/10/2022 04:02, Wayne Chang wrote: >> >>>> + power-domain-names: >>>> + items: >>>> + - const: xusb_host >>>> + - const: xusb_ss >>> >>> Drop 'xusb_'. >> >> The properties are constant and we use the name to get the power domain. >> >> tegra->genpd_dev_host = dev_pm_domain_attach_by_name(dev, "xusb_host"); >> >> tegra->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "xusb_ss"); >> >> we might not be able to drop the xusb_ > > These are new bindings, so why do say they are "constant"? New bindings > means you did not use them. If you used them before bindings... what can > we say? Don't? Not exactly. However, what we should do here is convert the legacy binding doc [0] and replace with this one. But yes we are stuck with the 'xusb_host' naming. Jon [0] Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt -- nvpublic
Powered by blists - more mailing lists