linux-kernel - Re: [PATCH v2 1/2] mm/page_reporting: Add checks for page_reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1uxLyaLlKp2sfkD@liuwe-devbox-debian-v2>
Date:   Fri, 28 Oct 2022 10:38:39 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Wei Liu <wei.liu@...nel.org>,
        Shradha Gupta <shradhagupta@...ux.microsoft.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [PATCH v2 1/2] mm/page_reporting: Add checks for
 page_reporting_order param

On Thu, Oct 27, 2022 at 01:22:07PM -0700, Andrew Morton wrote:
> On Wed, 26 Oct 2022 15:33:47 +0000 Wei Liu <wei.liu@...nel.org> wrote:
> 
> > On Thu, Sep 29, 2022 at 11:01:38PM -0700, Shradha Gupta wrote:
> > > Current code allows the page_reporting_order parameter to be changed
> > > via sysfs to any integer value.  The new value is used immediately
> > > in page reporting code with no validation, which could cause incorrect
> > > behavior.  Fix this by adding validation of the new value.
> > > Export this parameter for use in the driver that is calling the
> > > page_reporting_register().
> > > This is needed by drivers like hv_balloon to know the order of the
> > > pages reported. Traditionally the values provided in the kernel boot
> > > line or subsequently changed via sysfs take priority therefore, if
> > > page_reporting_order parameter's value is set, it takes precedence
> > > over the value passed while registering with the driver.
> > > 
> > > Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> > 
> > Andrew and other MM reviewers, can I get an ack / nack for this patch?
> 
> Looks OK to me.  Can this be merged via the hyperv tree?

Yes, I can take of merging it.

I will add your acked-by to the patch.

Thanks,
Wei.