linux-kernel - Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 11:58:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Venkata Prasad Potturu 
        <venkataprasad.potturu@....corp-partner.google.com>
Cc:     alsa-devel@...a-project.org, vsujithkumar.reddy@....com,
        Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, ssabakar@....com,
        Venkata Prasad Potturu <venkataprasad.potturu@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in
 machine driver

On Fri, Oct 28, 2022 at 04:04:41PM +0530, Venkata Prasad Potturu wrote:

> +static int tdm_mode = 0;
> +module_param_named(tdm_mode, tdm_mode, int, 0444);
> +MODULE_PARM_DESC(tdm_mode, "Set 1 for tdm mode, set 0 for i2s mode");

Why is this a module parameter - how would a user decide to set this?
Is it something that someone might want to change at runtime?

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)