linux-kernel - Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18b98740-6730-3c3a-c95b-c377cb355e77@suse.de>
Date:   Fri, 28 Oct 2022 13:11:34 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Pekka Paalanen <pekka.paalanen@...labora.com>,
        dri-devel@...ts.freedesktop.org, Hector Martin <marcan@...can.st>,
        Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        asahi@...ts.linux.dev
Subject: Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

Hi

Am 28.10.22 um 12:04 schrieb Ville Syrjälä:
> On Thu, Oct 27, 2022 at 01:08:24PM +0200, Thomas Zimmermann wrote:
>> I trust you when you say that <native>->XRGB8888 is not enough. But
>> although I've read your replies, I still don't understand why this
>> switch is necessary.
>>
>> Why don't we call drm_fb_build_fourcc_list() with the native
>> format/formats and let it append a number of formats, such as adding
>> XRGB888, adding ARGB8888 if necessary, adding ARGB2101010 if necessary.
>> Each with a elaborate comment why and which userspace needs the format. (?)
> 
> Are you saying there is some real userspace that breaks without
> the alpha formats? That would already be broken on many devices.

We should scrap them all IMHO, unless the hardware really supports them. 
See the other discussion on this patch's v2 as well.

Best regards
Thomas

> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)