linux-kernel - Re: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20019699-40a7-37d6-4b9b-06446183338f@linaro.org>
Date:   Fri, 28 Oct 2022 08:47:22 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Vidya Sagar <vidyas@...dia.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, thierry.reding@...il.com,
        jonathanh@...dia.com, mperttunen@...dia.com
Cc:     devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support

On 28/10/2022 08:09, Vidya Sagar wrote:
> 
> 
> On 10/28/2022 2:48 AM, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 27/10/2022 01:12, Vidya Sagar wrote:
>>> Add support for ECAM aperture for Tegra234.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
>>> ---
>>>   .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml  | 10 ++++++++--
>>>   .../devicetree/bindings/pci/snps,dw-pcie.yaml          |  2 +-
>>>   2 files changed, 9 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>>> index 75da3e8eecb9..15cc2d2055bb 100644
>>> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>>> @@ -27,6 +27,7 @@ properties:
>>>         - nvidia,tegra234-pcie
>>>
>>>     reg:
>>> +    minItems: 4
>>>       items:
>>>         - description: controller's application logic registers
>>>         - description: configuration registers
>>> @@ -35,13 +36,17 @@ properties:
>>>             available for software access.
>>>         - description: aperture where the Root Port's own configuration
>>>             registers are available.
>>> +      - description: aperture to access the configuration space through ECAM.
>>> +          This is applicable only for Tegra234.
>>
>> Then restrict it per compatible in allOf
>>
> 
> Thanks Krzysztof for your review.
> For a similar change here 
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20220707081301.29961-3-vidyas@nvidia.com/ 
> Rob had said that may be it is not worth it.
> Let me know if you really want this change and I'll push a new patch.
> 

That's a bit different. Restricting it per variant works and should be
trivial.

Best regards,
Krzysztof