linux-kernel - Re: [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1vSDyZlZBaGyJyb@sirena.org.uk>
Date:   Fri, 28 Oct 2022 13:58:55 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
Cc:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        linux-kernel@...r.kernel.org, robh@...nel.org,
        alsa-devel@...a-project.org,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        devicetree@...r.kernel.org,
        angelogioacchino.delregno@...labora.corp-partner.google.com,
        Shengjiu Wang <shengjiu.wang@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>
Subject: Re: [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection

On Fri, Oct 28, 2022 at 08:54:31PM +0800, Ajye Huang wrote:

> Yes, the original version I tried the implementation on audio machine
> driver, but one person gave me an idea for this dmic.c
> Do you think it is appropriate on dmic.c?
>  If it isn't, I will add kcontrol into audio machine driver.  thanks

It's definitely a better fit somewhere else - like I said in reply to
the DT binding it's really a mux that sits between the DMICs and the DAI
so that's probably where a generic version should be implemented.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)