linux-kernel - Re: [PATCH] m68k: mac: Reword comment using double "in"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 20:01:01 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        Michael Schmitz <schmitzmic@...il.com>
Subject: Re: [PATCH] m68k: mac: Reword comment using double "in"

On Fri, Oct 28, 2022 at 10:30:26AM +0200, Geert Uytterhoeven wrote:
> People keep on sending (incorrect) patches to remove the second
> occurrence of the word "in".  Reword the comment to stop the inflood.
> 

Ah! People who aren't fluent in English think that duplicated "in" below
isn't OK, which after stripping that become nonsense without reading the
actual code.

> Suggested-by: Michael Schmitz <schmitzmic@...il.com>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> To be queued in the m68k branch for v6.2.

Should this patch be Cc: stable'ed so that no more trivial patches as
you mentioned?

> 
>  arch/m68k/mac/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
> index 4fab3479175865d4..c7cb29f0ff016360 100644
> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>  
>  	reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>  
> -	/* The bits of the byte go in in MSB order */
> +	/* The bits of the byte go into the RTC in MSB order */
>  

LGTM, thanks.

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)