linux-kernel - [PATCH] sparc: sbus: treat CPU index as integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20221028142715.2021166-1-Jason@zx2c4.com>
Date:   Fri, 28 Oct 2022 16:27:15 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: [PATCH] sparc: sbus: treat CPU index as integer

Using a `char` to fit a CPU index is too small, and assigning -1 to it
isn't correct either, since `char` is sometimes signed and sometimes
not. In this case, it's been fine since this driver only works on sparc,
but that will soon be changing when chars become unsigned everywhere. So
instead, use a normal `int` type, which matches the `int cpu` function
argument that this is being compared against.

Cc: David S. Miller <davem@...emloft.net>
Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
---
DaveM - this is part of the -funsigned-char work I've been accumulating
in my unsigned-char branch. If you want to take this as a fix for 6.1,
go ahead. Otherwise, Linus asked me to keep the 6.2 unsigned-char
patches together in my branch, so I'll take this, pending your Ack.
-Jason

 drivers/sbus/char/envctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/sbus/char/envctrl.c b/drivers/sbus/char/envctrl.c
index 843e830b5f87..ea914a7eaa7f 100644
--- a/drivers/sbus/char/envctrl.c
+++ b/drivers/sbus/char/envctrl.c
@@ -363,8 +363,8 @@ static int envctrl_read_cpu_info(int cpu, struct i2c_child_t *pchild,
 				 char mon_type, unsigned char *bufdata)
 {
 	unsigned char data;
-	int i;
-	char *tbl, j = -1;
+	int i, j = -1;
+	char *tbl;
 
 	/* Find the right monitor type and channel. */
 	for (i = 0; i < PCF8584_MAX_CHANNELS; i++) {
-- 
2.38.1