[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0737d433-0379-8aba-0ffb-efa278908c22@linaro.org>
Date: Thu, 27 Oct 2022 22:28:22 -0400
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Weilong Chen <chenweilong@...wei.com>, f.fangjian@...wei.com,
linus.walleij@...aro.org, yangyicong@...ilicon.com,
xuwei5@...wei.com, robh+dt@...nel.org, robh@...nel.org,
krzysztof.kozlowski+dt@...aro.org
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH next v2 2/2] dt-bindings: gpio: add entry for
hisilicon,ascend910-gpio
On 27/10/2022 22:24, Weilong Chen wrote:
> Add the new compatible for HiSilicon gpio controller driver.
>
> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
> ---
> Change since v1:
Thank you for your patch. There is something to discuss/improve.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/hisilicon,ascend910-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon common GPIO controller
> +
> +maintainers:
> + - Jay Fang <f.fangjian@...wei.com>
> +
> +description: |
No need for "|". Can be dropped.
> + The HiSilicon common GPIO controller can be used for many different
> + types of SoC such as Huawei Ascend AI series chips.
> +
> +properties:
> + compatible:
> + const: hisilicon,ascend910-gpio
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + ngpios:
> + minimum: 1
> + maximum: 32
> +
> +required:
> + - compatible
> + - gpio-controller
> + - '#gpio-cells'
Please use the same style of quotes in entire file - either ' or ".
> + - interrupts
> + - ngpios
> + - reg
The same order as appear in "properties:".
> +
> +additionalProperties: false
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists