linux-kernel - Re: [PATCH] kunit: Include missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 07:46:02 -0700
From:   Daniel Latypov <dlatypov@...gle.com>
To:     Bo Liu <liubo03@...pur.com>
Cc:     brendan.higgins@...ux.dev, davidgow@...gle.com,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: Include missing header

On Thu, Oct 27, 2022 at 11:31 PM Bo Liu <liubo03@...pur.com> wrote:
>
> The file debugfs.c missed the header debugfs.h, which
> resulted on the following warning:
>
> lib/kunit/debugfs.c:28:6: warning: no previous prototype for 'kunit_debugfs_cleanup' [-Wmissing-prototypes]
>  void kunit_debugfs_cleanup(void)
>       ^~~~~~~~~~~~~~~~~~~~~
> lib/kunit/debugfs.c:33:6: warning: no previous prototype for 'kunit_debugfs_init' [-Wmissing-prototypes]
>  void kunit_debugfs_init(void)
>       ^~~~~~~~~~~~~~~~~~
> lib/kunit/debugfs.c:92:6: warning: no previous prototype for 'kunit_debugfs_create_suite' [-Wmissing-prototypes]
>  void kunit_debugfs_create_suite(struct kunit_suite *suite)
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/kunit/debugfs.c:108:6: warning: no previous prototype for 'kunit_debugfs_destroy_suite' [-Wmissing-prototypes]
>  void kunit_debugfs_destroy_suite(struct kunit_suite *suite)
>
> Signed-off-by: Bo Liu <liubo03@...pur.com>

Tested-by: Daniel Latypov <dlatypov@...gle.com>

Looks good to me, one minor nit below.
Brendan, can you take a look when you get a moment?

Question for context: is there a plan to enable this flag by default
or something like that?
I was a bit surprised that -Wall doesn't seem to enable this flag when
I was testing locally.

> ---
>  lib/kunit/debugfs.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/kunit/debugfs.c b/lib/kunit/debugfs.c
> index 1048ef1b8d6e..83411075f614 100644
> --- a/lib/kunit/debugfs.c
> +++ b/lib/kunit/debugfs.c
> @@ -10,6 +10,7 @@
>  #include <kunit/test.h>
>
>  #include "string-stream.h"
> +#include "debugfs.h"

Very minor nit: could we swap the order of these?
#include "debugfs.h"
#include "string-stream.h"