linux-kernel - Re: [PATCH v1] coredump: Use vmsplice_to_pipe() for pipes in dump_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Oct 2022 15:20:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peilin Ye <yepeilin.cs@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     oe-kbuild-all@...ts.linux.dev, Peilin Ye <peilin.ye@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] coredump: Use vmsplice_to_pipe() for pipes in
 dump_emit_page()

Hi Peilin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.1-rc2 next-20221028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peilin-Ye/coredump-Use-vmsplice_to_pipe-for-pipes-in-dump_emit_page/20221029-085307
patch link:    https://lore.kernel.org/r/20221029005147.2553-1-yepeilin.cs%40gmail.com
patch subject: [PATCH v1] coredump: Use vmsplice_to_pipe() for pipes in dump_emit_page()
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/49da2daf3c9dc6a687c0f64c047bec6199f232af
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Peilin-Ye/coredump-Use-vmsplice_to_pipe-for-pipes-in-dump_emit_page/20221029-085307
        git checkout 49da2daf3c9dc6a687c0f64c047bec6199f232af
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/tls/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from net/tls/tls_sw.c:41:
>> include/linux/splice.h:84:56: warning: 'struct iov_iter' declared inside parameter list will not be visible outside of this definition or declaration
      84 | extern long vmsplice_to_pipe(struct file *file, struct iov_iter *iter,
         |                                                        ^~~~~~~~


vim +84 include/linux/splice.h

    64	
    65	typedef int (splice_actor)(struct pipe_inode_info *, struct pipe_buffer *,
    66				   struct splice_desc *);
    67	typedef int (splice_direct_actor)(struct pipe_inode_info *,
    68					  struct splice_desc *);
    69	
    70	extern ssize_t splice_from_pipe(struct pipe_inode_info *, struct file *,
    71					loff_t *, size_t, unsigned int,
    72					splice_actor *);
    73	extern ssize_t __splice_from_pipe(struct pipe_inode_info *,
    74					  struct splice_desc *, splice_actor *);
    75	extern ssize_t splice_to_pipe(struct pipe_inode_info *,
    76				      struct splice_pipe_desc *);
    77	extern ssize_t add_to_pipe(struct pipe_inode_info *,
    78				      struct pipe_buffer *);
    79	extern ssize_t splice_direct_to_actor(struct file *, struct splice_desc *,
    80					      splice_direct_actor *);
    81	extern long do_splice(struct file *in, loff_t *off_in,
    82			      struct file *out, loff_t *off_out,
    83			      size_t len, unsigned int flags);
  > 84	extern long vmsplice_to_pipe(struct file *file, struct iov_iter *iter,
    85				     unsigned int flags);
    86	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (291932 bytes)