linux-kernel - Re: [PATCH v22 2/2] ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Oct 2022 16:52:04 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     kernel@...gutronix.de, robh+dt@...nel.org, lgirdwood@...il.com,
        lee.jones@...aro.org, broonie@...nel.org,
        linux-arm-kernel@...ts.infradead.org, rui.zhang@...el.com,
        s.hauer@...gutronix.de, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org, linux-pm@...r.kernel.org,
        andreas@...nade.info, amitk@...nel.org,
        linux-hwmon@...r.kernel.org, alistair23@...il.com,
        devicetree@...r.kernel.org, linux@...ck-us.net, linux-imx@....com
Subject: Re: [PATCH v22 2/2] ARM: dts: imx7d-remarkable2: Enable
 silergy,sy7636a

On Mon, Oct 24, 2022 at 08:58:53PM +1000, Alistair Francis wrote:
> Enable the silergy,sy7636a and silergy,sy7636a-regulator on the
> reMarkable2.
> 
> Signed-off-by: Alistair Francis <alistair@...stair23.me>
> ---
>  arch/arm/boot/dts/imx7d-remarkable2.dts | 62 +++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts
> index a2a91bfdd98e..99ac0d242936 100644
> --- a/arch/arm/boot/dts/imx7d-remarkable2.dts
> +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts
> @@ -22,6 +22,27 @@ memory@...00000 {
>  		reg = <0x80000000 0x40000000>;
>  	};
>  
> +	thermal-zones {
> +		epd-thermal {
> +			thermal-sensors = <&epd_pmic>;
> +			polling-delay-passive = <30000>;
> +			polling-delay = <30000>;

Have a newline between properties and child node.

> +			trips {
> +				trip0 {
> +					temperature = <49000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <50000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +	};
> +
>  	reg_brcm: regulator-brcm {
>  		compatible = "regulator-fixed";
>  		regulator-name = "brcm_reg";
> @@ -84,6 +105,33 @@ wacom_digitizer: digitizer@9 {
>  	};
>  };
>  
> +&i2c4 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_i2c4>;
> +	pinctrl-1 = <&pinctrl_i2c4>;
> +	status = "okay";
> +
> +	epd_pmic: sy7636a@62 {

Node name should be generic while label could be specific, so maybe:

	sy7636a: pmic@62 {

> +		compatible = "silergy,sy7636a";
> +		reg = <0x62>;
> +		status = "okay";

We usually end property list with `status`.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_epdpmic>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		#thermal-sensor-cells = <0>;
> +

Move this newline one line below.

> +		epd-pwr-good-gpios = <&gpio6 21 GPIO_ACTIVE_HIGH>;
> +		regulators {
> +			reg_epdpmic: vcom {
> +				regulator-name = "vcom";
> +				regulator-boot-on;
> +			};
> +		};
> +	};
> +};
> +
>  &snvs_pwrkey {
>  	status = "okay";
>  };
> @@ -177,6 +225,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13	0x14
>  		>;
>  	};
>  
> +	pinctrl_epdpmic: epdpmicgrp {
> +		fsl,pins = <
> +			MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21 0x00000074
> +			MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014

You might want to align hex values like other pinctrl nodes?

Shawn

> +		>;
> +	};
> +
>  	pinctrl_i2c1: i2c1grp {
>  		fsl,pins = <
>  			MX7D_PAD_I2C1_SDA__I2C1_SDA		0x4000007f
> @@ -184,6 +239,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL		0x4000007f
>  		>;
>  	};
>  
> +	pinctrl_i2c4: i2c4grp {
> +		fsl,pins = <
> +			MX7D_PAD_I2C4_SDA__I2C4_SDA		0x4000007f
> +			MX7D_PAD_I2C4_SCL__I2C4_SCL		0x4000007f
> +		>;
> +	};
> +
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <
>  			MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
> -- 
> 2.37.3
>