lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y10hzXgvq+djdQEH@debian.me>
Date:   Sat, 29 Oct 2022 19:51:25 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Shaomin Deng <dengshaomin@...rlc.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmscan: delete rebundant word in comments

On Sat, Oct 29, 2022 at 06:04:31AM -0400, Shaomin Deng wrote:
> Delete the repeated word "that" in comments.
> 

Meh...

On what comment?

Also, on patch subject, s/rebundant/redundant/.

> Signed-off-by: Shaomin Deng <dengshaomin@...rlc.com>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 27a3f29c0181..2ad2fec6ed3f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -7053,7 +7053,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)

Ah! You mean balance_pgdat().

>  
>  		/*
>  		 * There should be no need to raise the scanning priority if
> -		 * enough pages are already being scanned that that high
> +		 * enough pages are already being scanned that high
>  		 * watermark would be met at 100% efficiency.
>  		 */
>  		if (kswapd_shrink_node(pgdat, &sc))

Dunno if the comment above is right.

I have already say to fellow @cdjrlc.com people that you and your team
**IGNORE** patch reviews. If you don't reply to this review, I would like
to just say NAK.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ