linux-kernel - Re: [PATCH hid v11 05/14] HID: bpf: allocate data memory for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210292119.BVdlRvot-lkp@intel.com>
Date:   Sat, 29 Oct 2022 21:45:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Greg KH <greg@...ah.com>, Jiri Kosina <jikos@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Shuah Khan <skhan@...uxfoundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Tero Kristo <tero.kristo@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-doc@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH hid v11 05/14] HID: bpf: allocate data memory for
 device_event BPF programs

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hid/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Tissoires/Introduce-eBPF-support-for-HID-devices/20221025-173852
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git master
patch link:    https://lore.kernel.org/r/20221025093458.457089-6-benjamin.tissoires%40redhat.com
patch subject: [PATCH hid v11 05/14] HID: bpf: allocate data memory for device_event BPF programs
config: nios2-randconfig-s033-20221028
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/a255f9be8a1f7ef40929e63e60e32df22adf2445
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Benjamin-Tissoires/Introduce-eBPF-support-for-HID-devices/20221025-173852
        git checkout a255f9be8a1f7ef40929e63e60e32df22adf2445
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/hid/ drivers/iio/cdc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
   drivers/hid/hid-core.c:637:15: sparse: sparse: memset with byte count of 110608
   drivers/hid/hid-core.c:862:15: sparse: sparse: memset with byte count of 110608
   drivers/hid/hid-core.c: note: in included file (through include/linux/hid.h):
>> include/linux/hid_bpf.h:122:94: sparse: sparse: Using plain integer as NULL pointer

vim +122 include/linux/hid_bpf.h

   112	
   113	#ifdef CONFIG_HID_BPF
   114	u8 *dispatch_hid_bpf_device_event(struct hid_device *hid, enum hid_report_type type, u8 *data,
   115					  u32 *size, int interrupt);
   116	int hid_bpf_connect_device(struct hid_device *hdev);
   117	void hid_bpf_disconnect_device(struct hid_device *hdev);
   118	void hid_bpf_destroy_device(struct hid_device *hid);
   119	void hid_bpf_device_init(struct hid_device *hid);
   120	#else /* CONFIG_HID_BPF */
   121	static inline u8 *dispatch_hid_bpf_device_event(struct hid_device *hid, enum hid_report_type type,
 > 122							u8 *data, u32 *size, int interrupt) { return 0; }
   123	static inline int hid_bpf_connect_device(struct hid_device *hdev) { return 0; }
   124	static inline void hid_bpf_disconnect_device(struct hid_device *hdev) {}
   125	static inline void hid_bpf_destroy_device(struct hid_device *hid) {}
   126	static inline void hid_bpf_device_init(struct hid_device *hid) {}
   127	#endif /* CONFIG_HID_BPF */
   128	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (137692 bytes)