linux-kernel - Re: [PATCH] bitfield: Use argument type for size comparison on Bitfield access macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210292131.qLcBBoS4-lkp@intel.com>
Date:   Sat, 29 Oct 2022 22:05:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
        ndesaulniers@...gle.com
Cc:     oe-kbuild-all@...ts.linux.dev, peterz@...radead.org,
        llvm@...ts.linux.dev, ashutosh.dixit@...el.com,
        andi.shyti@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bitfield: Use argument type for size comparison on
 Bitfield access macros

Hi Gwan-gyeong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.1-rc2 next-20221028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gwan-gyeong-Mun/bitfield-Use-argument-type-for-size-comparison-on-Bitfield-access-macros/20221029-133640
patch link:    https://lore.kernel.org/r/20221029053429.38381-1-gwan-gyeong.mun%40intel.com
patch subject: [PATCH] bitfield: Use argument type for size comparison on Bitfield access macros
config: arm64-randconfig-s032-20221028
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/91f22fce5cc0639c001bcf755c9dec0913073876
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gwan-gyeong-Mun/bitfield-Use-argument-type-for-size-comparison-on-Bitfield-access-macros/20221029-133640
        git checkout 91f22fce5cc0639c001bcf755c9dec0913073876
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/mm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> arch/arm64/mm/extable.c:22:23: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   arch/arm64/mm/extable.c:23:24: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   arch/arm64/mm/extable.c:36:24: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   arch/arm64/mm/extable.c:37:24: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)

vim +22 arch/arm64/mm/extable.c

d6e2cc56477538 Mark Rutland 2021-10-19  18  
2e77a62cb3a6d2 Mark Rutland 2021-10-19  19  static bool ex_handler_uaccess_err_zero(const struct exception_table_entry *ex,
2e77a62cb3a6d2 Mark Rutland 2021-10-19  20  					struct pt_regs *regs)
2e77a62cb3a6d2 Mark Rutland 2021-10-19  21  {
2e77a62cb3a6d2 Mark Rutland 2021-10-19 @22  	int reg_err = FIELD_GET(EX_DATA_REG_ERR, ex->data);
2e77a62cb3a6d2 Mark Rutland 2021-10-19  23  	int reg_zero = FIELD_GET(EX_DATA_REG_ZERO, ex->data);
2e77a62cb3a6d2 Mark Rutland 2021-10-19  24  
2e77a62cb3a6d2 Mark Rutland 2021-10-19  25  	pt_regs_write_reg(regs, reg_err, -EFAULT);
2e77a62cb3a6d2 Mark Rutland 2021-10-19  26  	pt_regs_write_reg(regs, reg_zero, 0);
2e77a62cb3a6d2 Mark Rutland 2021-10-19  27  
2e77a62cb3a6d2 Mark Rutland 2021-10-19  28  	regs->pc = get_ex_fixup(ex);
2e77a62cb3a6d2 Mark Rutland 2021-10-19  29  	return true;
2e77a62cb3a6d2 Mark Rutland 2021-10-19  30  }
2e77a62cb3a6d2 Mark Rutland 2021-10-19  31  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (140081 bytes)