linux-kernel - Re: [PATCH v5 0/3] iio: Support ROHM/Kionix kx022a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221029152348.31c36f1b@jic23-huawei>
Date:   Sat, 29 Oct 2022 15:23:48 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matti Vaittinen <mazziesaccount@...il.com>
Cc:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dmitry Rokosov <DDRokosov@...rdevices.ru>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Cosmin Tanislav <demonsingur@...il.com>,
        Jagath Jog J <jagathjog1996@...il.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/3] iio: Support ROHM/Kionix kx022a

On Mon, 24 Oct 2022 15:37:57 +0300
Matti Vaittinen <mazziesaccount@...il.com> wrote:

> Add initial support for ROHM/Kionix kx022a accelerometer

Series applied with minor tweaks as per individual replies +
Andy's RB found and added.

Applied to the togreg branch of iio.git and pushed out initially as
testing to see if 0-day can find anything we missed before I make
a mess of linux-next.

Thanks,

Jonathan

> 
> About the HW:
> KX022A accelerometer is a sensor which:
> 	- supports G-ranges of (+/-) 2, 4, 8, and 16G
> 	- can be connected to I2C or SPI
> 	- has internal HW FIFO buffer
> 	- supports various ODRs (output data rates)
> 	- support detecting special events like double tap or motion
> 	- can be configured to wake-up system when events are detected.
> 
> About the series:
> 
> This series adds support for only getting the accelerometer data and
> configuring the G-range / ODR via IIO. Motion detection or double-tap
> detection are not supported by the series. The other quite important but
> still missing piece is the runtime PM. Nevertheless, the driver should be
> usable and brings the basic support for getting accelerometer data.
> 
> Changelog v5:
> 	- KX022A: styling/print fixes.
> 	- KX022A: fix race for requesting IRQ/populating user-space
> 	  entries.
> 	- KX022A: fix few variable types
> 	- KX022A: drop unnecessary udelay()
> 	- MAINTAINERS: Change myself to be a maintainer.
> 
> Changelog v4: (More detailed log in individual patches)
> 	- KX022A: mostly styling/print fixes.
> 	- KX022A: fix return value from IRQ thread handler.
> 
> Changelog v3: (More detailed log in individual patches)
> 	- dt-bindings: fixed as suggested by Krzysztof
> 	- KX022A: multiple fixes as suggested by Andy
> 		- Fair to mention that couple of suggested changes are
> 		  not done (Some styling, boilerplate text in KConfig)
> 		  as there has been no consensus whether the suggested
> 		  changes improve situation. Ultimately the decision
> 		  whether these changes are mandatory lay on the
> 		  shoulders of the maintainers... Sorry for that.
> 	- Enable the FIFO without module param now that the "FIFO stuck"
> 	  issue can be prevented.
> 	- Fix potential race with time-stamp calculation when user-space
> 	  invokes the fifo flush.
> 	- Drop the already merged regulator patches.
> 
> Changelog v2: (More detailed log in individual patches)
> 	- dt-bindings: fixed as suggested by Krzysztof
> 	- dt-bindings: support both INT1 and INT2
> 	- KX022A: multiple fixes as suggested by Jonathan
> 	- fixed SPI driver after some testing
> 
> ---
> 
> Matti Vaittinen (3):
>   dt-bindings: iio: Add KX022A accelerometer
>   iio: accel: Support Kionix/ROHM KX022A accelerometer
>   MAINTAINERS: Add KX022A maintainer entry
> 
>  .../bindings/iio/accel/kionix,kx022a.yaml     |   65 +
>  MAINTAINERS                                   |    5 +
>  drivers/iio/accel/Kconfig                     |   21 +
>  drivers/iio/accel/Makefile                    |    3 +
>  drivers/iio/accel/kionix-kx022a-i2c.c         |   51 +
>  drivers/iio/accel/kionix-kx022a-spi.c         |   58 +
>  drivers/iio/accel/kionix-kx022a.c             | 1142 +++++++++++++++++
>  drivers/iio/accel/kionix-kx022a.h             |   82 ++
>  8 files changed, 1427 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml
>  create mode 100644 drivers/iio/accel/kionix-kx022a-i2c.c
>  create mode 100644 drivers/iio/accel/kionix-kx022a-spi.c
>  create mode 100644 drivers/iio/accel/kionix-kx022a.c
>  create mode 100644 drivers/iio/accel/kionix-kx022a.h
> 
> 
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780