linux-kernel - Re: [PATCH 1/2] usb: ehci-pci: Set PROBE_PREFER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1yFejAhNogYVpIW@google.com>
Date:   Fri, 28 Oct 2022 18:44:26 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS

On Fri, Oct 28, 2022 at 09:13:14PM -0400, Alan Stern wrote:
> However, I'm curious to know why this patch makes ehci-pci use 
> PROBE_PREFER_ASYNCHRONOUS even when CONFIG_PM isn't set, whereas the 2/2 
> patch makes xhci-pci use PROBE_PREFER_ASYNCHRONOUS only when CONFIG_PM 
> is set.

That's definitely a bug in patch 2. This has nothing (or, little; probe
order can technically affect the PM suspend/resume order) to do with
CONFIG_PM, except that the .pm hooks tend to sit nearby, and repeated
driver patching makes the author's eyes glaze over sometimes...

Thanks. v2 coming.

Brian