linux-kernel - Re: [PATCH] iomap: directly use logical block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221030082749.GA4949@lst.de>
Date:   Sun, 30 Oct 2022 09:27:49 +0100
From:   Christoph Hellwig <hch@....de>
To:     Keith Busch <kbusch@...a.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        hch@....de, djwong@...nel.org, bvanassche@....org,
        Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH] iomap: directly use logical block size

On Wed, Oct 26, 2022 at 09:51:33AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@...nel.org>
> 
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.

This looks reasonable.  But given that the blksz variable is only used
once, why not open code the bdev_logical_block_size in the conditional?