linux-kernel - RE: [PATCH v3 10/17] ufs: core: mcq: Use shared tags for MCQ mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Oct 2022 13:06:01 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Asutosh Das <quic_asutoshd@...cinc.com>,
        "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
        "quic_xiaosenh@...cinc.com" <quic_xiaosenh@...cinc.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "eddie.huang@...iatek.com" <eddie.huang@...iatek.com>,
        "daejun7.park@...sung.com" <daejun7.park@...sung.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "mani@...nel.org" <mani@...nel.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "quic_richardp@...cinc.com" <quic_richardp@...cinc.com>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 10/17] ufs: core: mcq: Use shared tags for MCQ mode

>  static int ufshcd_map_queues(struct Scsi_Host *shost)
This seems like an old version of ufshcd_map_queues - returns void now.
Needs rebase?

>  {
> -       int i, ret;
> +       int i, queue_offset = 0;
> +       struct ufs_hba *hba = shost_priv(shost);
> +
> +       if (!is_mcq_supported(hba)) {
> +               hba->nr_queues[HCTX_TYPE_DEFAULT] = 1;
> +               hba->nr_queues[HCTX_TYPE_READ] = 0;
> +               hba->nr_queues[HCTX_TYPE_POLL] = 1;
> +               hba->nr_hw_queues = 1;
> +       }
> 
>         for (i = 0; i < shost->nr_maps; i++) {
>                 struct blk_mq_queue_map *map = &shost->tag_set.map[i];
> 
> -               switch (i) {
> -               case HCTX_TYPE_DEFAULT:
> -               case HCTX_TYPE_POLL:
> -                       map->nr_queues = 1;
> -                       break;
> -               case HCTX_TYPE_READ:
> -                       map->nr_queues = 0;
> +               map->nr_queues = hba->nr_queues[i];
> +               if (!map->nr_queues)
>                         continue;
> -               default:
> -                       WARN_ON_ONCE(true);
> -               }
> -               map->queue_offset = 0;
> -               ret = blk_mq_map_queues(map);
Ditto.

Thanks,
Avri

> -               WARN_ON_ONCE(ret);
> +               map->queue_offset = queue_offset;
> +               if (i == HCTX_TYPE_POLL && !is_mcq_supported(hba))
> +                       map->queue_offset = 0;
> +
> +               blk_mq_map_queues(map);
> +               queue_offset += map->nr_queues;
>         }
> 
>         return 0;
> --
> 2.7.4