linux-kernel - Re: [PATCH 1/3] blk-mq: remove redundant call to blk_freeze_queue_start in blk_mq_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb1acbc.15062f.18429642056.Coremail.nickyc975@zju.edu.cn>
Date:   Sun, 30 Oct 2022 22:55:38 +0800 (GMT+08:00)
From:   "Jinlong Chen" <nickyc975@....edu.cn>
To:     "Bart Van Assche" <bvanassche@....org>
Cc:     axboe@...nel.dk, hch@....de, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] blk-mq: remove redundant call to
 blk_freeze_queue_start in blk_mq_destroy_queue

> > So I think there is a redundant call to blk_freeze_queue_start(), we
> > just need to call blk_mq_freeze_queue_wait() after calling
> > blk_queue_start_drain().
> 
> I think it is on purpose that blk_queue_start_drain() freezes the 
> request queue and never unfreezes it. So if you want to change this 
> behavior it's up to you to motivate why you want to change this behavior 
> and also why it is safe to make that change. See also commit 
> d3cfb2a0ac0b ("block: block new I/O just after queue is set as dying").
> 
> Bart.

I think there might be some misunderstanding. I didn't touch
blk_queue_start_drain(), so its behavior is not changed. What I have done
is just replacing blk_freeze_queue() with blk_mq_freeze_queue_wait() in
blk_mq_destroy_queue().

See:
- https://lore.kernel.org/linux-block/20221030084011.GA5262@lst.de/T/#t

Thanks!
Jinlong Chen