linux-kernel - Re: [PATCH] btrfs: Fix a memory allocation failure test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c92f908-f7e0-30d1-13a0-0230cc99f9ca@suse.com>
Date:   Sun, 30 Oct 2022 20:32:08 +0200
From:   Nikolay Borisov <nborisov@...e.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH] btrfs: Fix a memory allocation failure test



On 30.10.22 г. 9:35 ч., Christophe JAILLET wrote:
> 'dip' is tested instead of 'dip->csums'.
> Fix it.
> 
> Fixes: 642c5d34da53 ("btrfs: allocate the btrfs_dio_private as part of the iomap dio bio")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>


Reviewed-by: Nikolay Borisov <nborisov@...e.com>

> ---
>   fs/btrfs/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 966cc050cdbb..3bbd2dc6282f 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -8078,7 +8078,7 @@ static void btrfs_submit_direct(const struct iomap_iter *iter,
>   		 */
>   		status = BLK_STS_RESOURCE;
>   		dip->csums = kcalloc(nr_sectors, fs_info->csum_size, GFP_NOFS);
> -		if (!dip)
> +		if (!dip->csums)
>   			goto out_err;
>   
>   		status = btrfs_lookup_bio_sums(inode, dio_bio, dip->csums);