| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y170TZoIp1WBIwU4@smile.fi.intel.com>
Date: Mon, 31 Oct 2022 00:01:49 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Weilong Chen <chenweilong@...wei.com>
Cc: yangyicong@...ilicon.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, wsa@...nel.org,
f.fainelli@...il.com, jarkko.nikula@...ux.intel.com,
jdelvare@...e.de, william.zhang@...adcom.com, jsd@...ihalf.com,
conor.dooley@...rochip.com, phil.edworthy@...esas.com,
tharunkumar.pasumarthi@...rochip.com, semen.protsenko@...aro.org,
kfting@...oton.com, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next v9 1/4] i2c: hisi: Add initial device tree support
On Sat, Oct 29, 2022 at 07:59:36PM +0800, Weilong Chen wrote:
> The HiSilicon I2C controller can be used on embedded platform, which
> boot from devicetree.
...
> +#include <linux/acpi.h>
> +#include <linux/of.h>
Why?
...
> +#ifdef CONFIG_ACPI
Why?
...
> +#ifdef CONFIG_OF
Why?
...
> - .acpi_match_table = hisi_i2c_acpi_ids,
> + .acpi_match_table = ACPI_PTR(hisi_i2c_acpi_ids),
Why?
...
> + .of_match_table = of_match_ptr(hisi_i2c_dts_ids),
Why of_match_ptr()?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists