linux-kernel - Re: [PATCH] soc: ux500: do not directly dereference _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9pDrV1P7GVg74xHTbUaVT5Lq8urvyYCgbu=sJLApwHHNw@mail.gmail.com>
Date:   Sun, 30 Oct 2022 23:30:46 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] soc: ux500: do not directly dereference __iomem

Hi Linus,

On Sun, Oct 23, 2022 at 9:57 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Sparse reports that calling add_device_randomness() on `uid` is a
> violation of address spaces. And indeed the next usage uses readl()
> properly, but that was left out when passing it toadd_device_
> randomness(). So instead copy the whole thing to the stack first.
>
> Fixes: 4040d10a3d44 ("ARM: ux500: add DB serial number to entropy pool")
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: stable@...r.kernel.org
> Link: https://lore.kernel.org/all/202210230819.loF90KDh-lkp@intel.com/
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Just thought I'd follow up on this.


Jason