linux-kernel - Re: [PATCH 07/10] arm64: dts: qcom: sm6350-lena: Provide power to SDHCI 2 (SDCard slot)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2aa7be3f-0b92-f280-d2c0-9283d8900b92@somainline.org>
Date:   Mon, 31 Oct 2022 22:14:20 +0100
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>,
        phone-devel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Luca Weiss <luca@...tu.xyz>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] arm64: dts: qcom: sm6350-lena: Provide power to
 SDHCI 2 (SDCard slot)



On 30.10.2022 08:32, Marijn Suijten wrote:
> Without power the SDCard slot / hardware remains dormant.
> 
> Like many other platforms these regulators are used exclusively by
> SDHCI, and have their maximum voltage decreased to what downstream sets
> on the consumer side.  Additionally the SDHCI driver supports setting a
> load, for which the regulator definition is extended much the same.
> 
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  .../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 1aaa9612b061..5cb76026ef67 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> @@ -219,8 +219,13 @@ pm6150l_l5: ldo5 {
>  
>  		pm6150l_l6: ldo6 {
>  			regulator-min-microvolt = <1700000>;
> -			regulator-max-microvolt = <3544000>;
> +			regulator-max-microvolt = <2950000>;
>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allow-set-load;
> +			regulator-allowed-modes =
> +			    <RPMH_REGULATOR_MODE_LPM
> +			     RPMH_REGULATOR_MODE_HPM>;
> +
>  		};
>  
>  		pm6150l_l7: ldo7 {
> @@ -237,8 +242,13 @@ pm6150l_l8: ldo8 {
>  
>  		pm6150l_l9: ldo9 {
>  			regulator-min-microvolt = <2700000>;
> -			regulator-max-microvolt = <3544000>;
> +			regulator-max-microvolt = <2960000>;
>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allow-set-load;
> +			regulator-allowed-modes =
> +			    <RPMH_REGULATOR_MODE_LPM
> +			     RPMH_REGULATOR_MODE_HPM>;
> +
>  		};
>  
>  		pm6150l_l10: ldo10 {
> @@ -300,6 +310,9 @@ sd-cd-pins {
>  &sdhc_2 {
>  	status = "okay";
>  
> +	vmmc-supply = <&pm6150l_l9>;
> +	vqmmc-supply = <&pm6150l_l6>;
> +
>  	cd-gpios = <&tlmm 94 GPIO_ACTIVE_HIGH>;
>  };
>