linux-kernel - Re: [PATCH net-next V4] net: lan743x: Add support to SGMII register dump for PCI11010/PCI11414 chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 16:41:07 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <Bryan.Whitehead@...rochip.com>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next V4] net: lan743x: Add support to SGMII register
 dump for PCI11010/PCI11414 chips

On Mon, 31 Oct 2022 12:23:36 +0530 Raju Lakkaraju wrote:
> > You can then read the values in a loop. And inside that loop you can
> > handle errors (perhaps avoiding the need for lan743x_sgmii_dump_read()
> > which seems rather unnecessary as lan743x_sgmii_read() already prints
> > errors).
> > 
> > FWIW I like Andrew's suggestion from v3 to use version as a bitfield, too.  
> 
> I will implement Andrew's suggestion in my next regdump function patch.
> Is it OK ?

SG, thanks!