linux-kernel - Re: [PATCH v10 1/4] Input: Add driver for Cypress Generation 5 touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2BfrUx9gzaNhb4I@google.com>
Date:   Mon, 31 Oct 2022 16:52:13 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, linus.walleij@...aro.org,
        robh+dt@...nel.org, shawnguo@...nel.org, rydberg@...math.org,
        alistair23@...il.com, s.hauer@...gutronix.de, andreas@...nade.info,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Mylène Josserand 
        <mylene.josserand@...tlin.com>, Peter Geis <pgwipeout@...il.com>
Subject: Re: [PATCH v10 1/4] Input: Add driver for Cypress Generation 5
 touchscreen

On Wed, Oct 26, 2022 at 09:49:05PM +1000, Alistair Francis wrote:
> This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> controllers. This driver supports only the I2C bus but it uses regmap
> so SPI support could be added later.
> The touchscreen can retrieve some defined zone that are handled as
> buttons (according to the hardware). That is why it handles
> button and multitouch events.
> 
> Reviewed-by: Maxime Ripard <maxime.ripard@...tlin.com>
> Signed-off-by: Mylène Josserand <mylene.josserand@...tlin.com>
> Signed-off-by: Alistair Francis <alistair@...stair23.me>
> Tested-by: Andreas Kemnade <andreas@...nade.info> # Kobo Clara HD
> Tested-by: Peter Geis <pgwipeout@...il.com>

While I wish we did not have to parse what is essentially HID data
ourselves and basically repeated what i2c-hid does, I understand that
the firmware is not exactly i2c-hid compatible...

Applied, thank you.

-- 
Dmitry