linux-kernel - [PATCH net] openvswitch: add missing resv_start_op initialization for dp_vport_genl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 16:12:10 +0800
From:   Ziyang Xuan <william.xuanziyang@...wei.com>
To:     <pshelar@....org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <dev@...nvswitch.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: [PATCH net] openvswitch: add missing resv_start_op initialization for dp_vport_genl_family

I got a warning using the latest mainline codes to start vms as following:

===================================================
WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 genl_register_family+0x6c/0x76c
CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43
...
Call trace:
 genl_register_family+0x6c/0x76c
 dp_init+0xa8/0x124
 do_one_initcall+0x84/0x450

It is because that commit 9c5d03d36251 ("genetlink: start to validate
reserved header bytes") has missed the resv_start_op initialization
for dp_vport_genl_family, and commit ce48ebdd5651 ("genetlink: limit
the use of validation workarounds to old ops") add checking warning.

Add resv_start_op initialization for dp_vport_genl_family to fix it.

Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>
---
 net/openvswitch/datapath.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 155263e73512..8b84869eb2ac 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -2544,6 +2544,7 @@ struct genl_family dp_vport_genl_family __ro_after_init = {
 	.parallel_ops = true,
 	.small_ops = dp_vport_genl_ops,
 	.n_small_ops = ARRAY_SIZE(dp_vport_genl_ops),
+	.resv_start_op = OVS_VPORT_CMD_SET + 1,
 	.mcgrps = &ovs_dp_vport_multicast_group,
 	.n_mcgrps = 1,
 	.module = THIS_MODULE,
-- 
2.25.1